test: update

Author: alexander-akait

lib/Server.js

@@ -3138,10 +3138,7 @@ class Server {
       true,
     ).hostname;
 
-    // allow requests with explicit IPv4 or IPv6-address if allowIP is true.
-    // Note that IP should not be automatically allowed for Origin headers,
-    // otherwise an untrusted remote IP host can send requests.
-    //
+    // always allow requests with explicit IPv4 or IPv6-address.
     // A note on IPv6 addresses:
     // hostHeader will always contain the brackets denoting
     // an IPv6-address in URLs,

test/e2e/__snapshots__/allowed-hosts.test.js.snap.webpack5

@@ -282,32 +282,6 @@ exports[`allowed hosts should disconnect web client using localhost to web socke
 
 exports[`allowed hosts should disconnect web client using localhost to web socket server with the "auto" value ("ws"): page errors 1`] = `[]`;
 
-exports[`allowed hosts should disconnect web client with origin header containing an IP address with the "auto" value ("sockjs"): console messages 1`] = `
-[
-  "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
-  "[HMR] Waiting for update signal from WDS...",
-  "Hey.",
-  "[webpack-dev-server] Invalid Host/Origin header",
-  "[webpack-dev-server] Disconnected!",
-  "[webpack-dev-server] Trying to reconnect...",
-]
-`;
-
-exports[`allowed hosts should disconnect web client with origin header containing an IP address with the "auto" value ("sockjs"): page errors 1`] = `[]`;
-
-exports[`allowed hosts should disconnect web client with origin header containing an IP address with the "auto" value ("ws"): console messages 1`] = `
-[
-  "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
-  "[HMR] Waiting for update signal from WDS...",
-  "Hey.",
-  "[webpack-dev-server] Invalid Host/Origin header",
-  "[webpack-dev-server] Disconnected!",
-  "[webpack-dev-server] Trying to reconnect...",
-]
-`;
-
-exports[`allowed hosts should disconnect web client with origin header containing an IP address with the "auto" value ("ws"): page errors 1`] = `[]`;
-
 exports[`allowed hosts should disconnect web socket client using custom hostname from web socket server with the "auto" value based on the "host" header ("sockjs"): console messages 1`] = `
 [
   "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",

test/e2e/allowed-hosts.test.js

@@ -1206,86 +1206,6 @@ describe("allowed hosts", () => {
         await server.stop();
       }
     });
-
-    it(`should disconnect web client with origin header containing an IP address with the "auto" value ("${webSocketServer}")`, async () => {
-      const devServerHost = "127.0.0.1";
-      const devServerPort = port1;
-      const proxyHost = devServerHost;
-      const proxyPort = port2;
-
-      const compiler = webpack(config);
-      const devServerOptions = {
-        client: {
-          webSocketURL: {
-            port: port2,
-          },
-        },
-        webSocketServer,
-        port: devServerPort,
-        host: devServerHost,
-        allowedHosts: "auto",
-      };
-      const server = new Server(devServerOptions, compiler);
-
-      await server.start();
-
-      function startProxy(callback) {
-        const app = express();
-
-        app.use(
-          "/",
-          createProxyMiddleware({
-            // Emulation
-            onProxyReqWs: (proxyReq) => {
-              proxyReq.setHeader("origin", "http://192.168.1.1/");
-            },
-            target: `http://${devServerHost}:${devServerPort}`,
-            ws: true,
-            changeOrigin: true,
-            logLevel: "warn",
-          }),
-        );
-
-        return app.listen(proxyPort, proxyHost, callback);
-      }
-
-      const proxy = await new Promise((resolve) => {
-        const proxyCreated = startProxy(() => {
-          resolve(proxyCreated);
-        });
-      });
-
-      const { page, browser } = await runBrowser();
-
-      try {
-        const pageErrors = [];
-        const consoleMessages = [];
-
-        page
-          .on("console", (message) => {
-            consoleMessages.push(message);
-          })
-          .on("pageerror", (error) => {
-            pageErrors.push(error);
-          });
-
-        await page.goto(`http://${proxyHost}:${proxyPort}/`, {
-          waitUntil: "networkidle0",
-        });
-
-        expect(
-          consoleMessages.map((message) => message.text()),
-        ).toMatchSnapshot("console messages");
-        expect(pageErrors).toMatchSnapshot("page errors");
-      } catch (error) {
-        throw error;
-      } finally {
-        proxy.close();
-
-        await browser.close();
-        await server.stop();
-      }
-    });
   }
 
   describe("check host headers", () => {