test: mock console.error for proxy option tests and verify error logging

Author: bjohansebas

test/server/proxy-option.test.js

@@ -139,6 +139,7 @@ const proxyWithRouterAsObject = [
 describe("proxy option", () => {
   let proxyServer1;
   let proxyServer2;
+  let consoleMock;
 
   async function listenProxyServers() {
     const proxyApp1 = express();
@@ -834,16 +835,9 @@ describe("proxy option", () => {
   describe("should work and respect `logger` option", () => {
     let server;
     let req;
-    let customLogProvider;
 
     beforeAll(async () => {
-      customLogProvider = {
-        log: jest.fn(),
-        debug: jest.fn(),
-        info: jest.fn(),
-        warn: jest.fn(),
-        error: jest.fn(),
-      };
+      consoleMock = jest.spyOn(console, "error");
 
       const compiler = webpack([config, config]);
 
@@ -853,7 +847,7 @@ describe("proxy option", () => {
             {
               context: "/my-path",
               target: "http://unknown:1234",
-              logger: customLogProvider,
+              logger: console,
             },
           ],
           port: port3,
@@ -869,6 +863,7 @@ describe("proxy option", () => {
     });
 
     afterAll(async () => {
+      consoleMock.mockRestore();
       await server.stop();
       await closeProxyServers();
     });
@@ -877,25 +872,17 @@ describe("proxy option", () => {
       it("respects a proxy option when a request path is matched", async () => {
         await req.get("/my-path");
 
-        expect(customLogProvider.error).toHaveBeenCalledTimes(1);
+        expect(consoleMock).toHaveBeenCalledTimes(1);
       });
     });
   });
 
   describe("should work and respect the `infrastructureLogging.level` option", () => {
     let server;
     let req;
-    let customLogProvider;
+    let loggerSpy;
 
     beforeAll(async () => {
-      customLogProvider = {
-        log: jest.fn(),
-        debug: jest.fn(),
-        info: jest.fn(),
-        warn: jest.fn(),
-        error: jest.fn(),
-      };
-
       const compiler = webpack({
         ...config,
         infrastructureLogging: { level: "error" },
@@ -907,14 +894,15 @@ describe("proxy option", () => {
             {
               context: "/my-path",
               target: "http://unknown:1234",
-              logger: customLogProvider,
             },
           ],
           port: port3,
         },
         compiler,
       );
 
+      loggerSpy = jest.spyOn(server.logger, "error");
+
       await server.start();
 
       await listenProxyServers();
@@ -923,6 +911,7 @@ describe("proxy option", () => {
     });
 
     afterAll(async () => {
+      loggerSpy.mockRestore();
       await server.stop();
       await closeProxyServers();
     });
@@ -931,25 +920,17 @@ describe("proxy option", () => {
       it("respects a proxy option when a request path is matched", async () => {
         await req.get("/my-path");
 
-        expect(customLogProvider.error).toHaveBeenCalledTimes(1);
+        expect(loggerSpy).toHaveBeenCalledTimes(1);
       });
     });
   });
 
   describe("should work and respect the `infrastructureLogging.level` option with `none` value", () => {
     let server;
     let req;
-    let customLogProvider;
+    let loggerSpy;
 
     beforeAll(async () => {
-      customLogProvider = {
-        log: jest.fn(),
-        debug: jest.fn(),
-        info: jest.fn(),
-        warn: jest.fn(),
-        error: jest.fn(),
-      };
-
       const compiler = webpack({
         ...config,
         infrastructureLogging: { level: "none" },
@@ -961,28 +942,31 @@ describe("proxy option", () => {
             {
               context: "/my-path",
               target: "http://unknown:1234",
-              logger: customLogProvider,
             },
           ],
           port: port3,
         },
         compiler,
       );
 
+      loggerSpy = jest.spyOn(server.logger, "error");
+
       await server.start();
 
       req = request(server.app);
     });
 
     afterAll(async () => {
+      loggerSpy.mockRestore();
       await server.stop();
     });
 
     describe("target", () => {
       it("respects a proxy option when a request path is matched", async () => {
         await req.get("/my-path");
 
-        expect(customLogProvider.error).toHaveBeenCalledTimes(0);
+        // Since infrastructureLogging.level is set to "none", no error logs should be produced
+        expect(loggerSpy).toHaveBeenCalledTimes(0);
       });
     });
   });