Skip to content

Commit 9704dc5

Browse files
chore: upgrade selfsigned to v5 and remove node-forge dependency (#5618)
* chore: upgrade selfsigned to v5 and remove node-forge dependency * chore: upgrade selfsigned to v5.5.0 Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> --------- Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com> Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
1 parent 92bf644 commit 9704dc5

File tree

3 files changed

+257
-19
lines changed

3 files changed

+257
-19
lines changed

lib/Server.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,10 +1241,14 @@ class Server {
12411241
const selfsigned = require("selfsigned");
12421242

12431243
const attributes = [{ name: "commonName", value: "localhost" }];
1244-
const pems = selfsigned.generate(attributes, {
1244+
const notBeforeDate = new Date();
1245+
const notAfterDate = new Date();
1246+
notAfterDate.setDate(notAfterDate.getDate() + 30);
1247+
const pems = await selfsigned.generate(attributes, {
12451248
algorithm: "sha256",
1246-
days: 30,
12471249
keySize: 2048,
1250+
notBeforeDate,
1251+
notAfterDate,
12481252
extensions: [
12491253
{
12501254
name: "basicConstraints",

package-lock.json

Lines changed: 250 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"open": "^10.0.3",
6767
"p-retry": "^6.2.0",
6868
"schema-utils": "^4.2.0",
69-
"selfsigned": "^2.4.1",
69+
"selfsigned": "^5.5.0",
7070
"serve-index": "^1.9.1",
7171
"sockjs": "^0.3.24",
7272
"spdy": "^4.0.2",

0 commit comments

Comments
 (0)