chore: more tests

Author: bjohansebas

test/e2e/__snapshots__/logging.test.js.snap.webpack5

@@ -1,5 +1,55 @@
 // Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
 
+exports[`logging plugin mode should work and do not log messages about hot and live reloading is enabled 1`] = `
+[
+  "[webpack-dev-server] Server started: Hot Module Replacement disabled, Live Reloading disabled, Progress disabled, Overlay enabled.",
+  "Hey.",
+]
+`;
+
+exports[`logging plugin mode should work and log errors by default 1`] = `
+[
+  "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
+  "[HMR] Waiting for update signal from WDS...",
+  "Hey.",
+  "[webpack-dev-server] Errors while compiling. Reload prevented.",
+  "[webpack-dev-server] ERROR
+Error from compilation",
+]
+`;
+
+exports[`logging plugin mode should work and log message about live reloading is enabled 1`] = `
+[
+  "[webpack-dev-server] Server started: Hot Module Replacement disabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
+  "Hey.",
+]
+`;
+
+exports[`logging plugin mode should work and log messages about hot and live reloading is enabled 1`] = `
+[
+  "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
+  "[HMR] Waiting for update signal from WDS...",
+  "Hey.",
+]
+`;
+
+exports[`logging plugin mode should work and log warnings by default 1`] = `
+[
+  "[webpack-dev-server] Server started: Hot Module Replacement enabled, Live Reloading enabled, Progress disabled, Overlay enabled.",
+  "[HMR] Waiting for update signal from WDS...",
+  "Hey.",
+  "[webpack-dev-server] Warnings while compiling.",
+  "[webpack-dev-server] WARNING
+Warning from compilation",
+]
+`;
+
+exports[`logging plugin mode should work when the "client.logging" is "none" 1`] = `
+[
+  "Hey.",
+]
+`;
+
 exports[`logging should work and do not log messages about hot and live reloading is enabled (ws) 1`] = `
 [
   "[webpack-dev-server] Server started: Hot Module Replacement disabled, Live Reloading disabled, Progress disabled, Overlay enabled.",

test/e2e/logging.test.js

@@ -5,6 +5,7 @@ const fs = require("graceful-fs");
 const webpack = require("webpack");
 const Server = require("../../lib/Server");
 const config = require("../fixtures/client-config/webpack.config");
+const compile = require("../helpers/compile");
 const HTMLGeneratorPlugin = require("../helpers/html-generator-plugin");
 const runBrowser = require("../helpers/run-browser");
 const port = require("../ports-map").logging;
@@ -241,4 +242,124 @@ describe("logging", () => {
       });
     }
   }
+
+  describe("plugin mode", () => {
+    const pluginCases = [
+      {
+        title:
+          "should work and log messages about hot and live reloading is enabled",
+        devServerOptions: {
+          hot: true,
+        },
+      },
+      {
+        title: "should work and log message about live reloading is enabled",
+        devServerOptions: {
+          hot: false,
+        },
+      },
+      {
+        title:
+          "should work and do not log messages about hot and live reloading is enabled",
+        devServerOptions: {
+          liveReload: false,
+          hot: false,
+        },
+      },
+      {
+        title: "should work and log warnings by default",
+        webpackOptions: {
+          plugins: [
+            {
+              apply(compiler) {
+                compiler.hooks.thisCompilation.tap(
+                  "warnings-webpack-plugin",
+                  (compilation) => {
+                    compilation.warnings.push(
+                      new Error("Warning from compilation"),
+                    );
+                  },
+                );
+              },
+            },
+            new HTMLGeneratorPlugin(),
+          ],
+        },
+      },
+      {
+        title: "should work and log errors by default",
+        webpackOptions: {
+          plugins: [
+            {
+              apply(compiler) {
+                compiler.hooks.thisCompilation.tap(
+                  "warnings-webpack-plugin",
+                  (compilation) => {
+                    compilation.errors.push(
+                      new Error("Error from compilation"),
+                    );
+                  },
+                );
+              },
+            },
+            new HTMLGeneratorPlugin(),
+          ],
+        },
+      },
+      {
+        title: 'should work when the "client.logging" is "none"',
+        devServerOptions: {
+          client: {
+            logging: "none",
+          },
+        },
+      },
+    ];
+
+    for (const testCase of pluginCases) {
+      it(`${testCase.title}`, async () => {
+        const compiler = webpack({ ...config, ...testCase.webpackOptions });
+        const devServerOptions = {
+          port,
+          ...testCase.devServerOptions,
+        };
+        const server = new Server(devServerOptions);
+
+        server.apply(compiler);
+
+        await compile(compiler, port);
+
+        const { page, browser } = await runBrowser();
+
+        try {
+          const consoleMessages = [];
+
+          page.on("console", (message) => {
+            consoleMessages.push(message);
+          });
+
+          await page.goto(`http://127.0.0.1:${port}/`, {
+            waitUntil: "networkidle0",
+          });
+
+          expect(
+            consoleMessages.map((message) =>
+              message
+                .text()
+                .replaceAll("\\", "/")
+                .replaceAll(
+                  new RegExp(process.cwd().replaceAll("\\", "/"), "g"),
+                  "<cwd>",
+                ),
+            ),
+          ).toMatchSnapshot();
+        } finally {
+          await browser.close();
+          await new Promise((resolve) => {
+            compiler.close(resolve);
+          });
+        }
+      });
+    }
+  });
 });