feat: use compiler.platform to determine the target

Author: bjohansebas

lib/Server.js

@@ -560,42 +560,9 @@ class Server {
    * @returns {boolean} true when target is `web`, otherwise false
    */
   static isWebTarget(compiler) {
-    if (compiler.platform && compiler.platform.web) {
-      return compiler.platform.web;
-    }
-
-    // TODO improve for the next major version and keep only `webTargets` to fallback for old versions
-    if (
-      compiler.options.externalsPresets &&
-      compiler.options.externalsPresets.web
-    ) {
-      return true;
-    }
-
-    if (
-      compiler.options.resolve.conditionNames &&
-      compiler.options.resolve.conditionNames.includes("browser")
-    ) {
-      return true;
-    }
-
-    const webTargets = [
-      "web",
-      "webworker",
-      "electron-preload",
-      "electron-renderer",
-      "nwjs",
-      "node-webkit",
-
-      undefined,
-      null,
-    ];
-
-    if (Array.isArray(compiler.options.target)) {
-      return compiler.options.target.some((r) => webTargets.includes(r));
-    }
-
-    return webTargets.includes(/** @type {string} */ (compiler.options.target));
+    return (
+      compiler.platform?.web || compiler.options.externalsPresets?.web || false
+    );
   }
 
   /**
@@ -813,18 +780,9 @@ class Server {
         /** @type {MultiCompiler} */
         (this.compiler).compilers.find(
           (config) =>
-            (config.options.externalsPresets &&
-              config.options.externalsPresets.web) ||
-            [
-              "web",
-              "webworker",
-              "electron-preload",
-              "electron-renderer",
-              "node-webkit",
-
-              undefined,
-              null,
-            ].includes(/** @type {string} */ (config.options.target)),
+            config.options.externalsPresets?.web ||
+            config.platform?.web ||
+            false,
         );
 
       if (compilerWithWebPreset) {

migration-v6.md

@@ -37,6 +37,10 @@ This document serves as a migration guide for `webpack-dev-server@6.0.0`.
   };
   ```
 
+- Now, webpack-dev-server adds WebSocket communication only when the `target` is set to a web-compatible environment or when `externalsPresets` includes `web`.
+
+Previously, it also injected WebSocket communication if `resolve` contained a `conditionNames` entry with `browser`.
+
 ## Deprecations
 
 - The static methods `internalIP` and `internalIPSync` were removed. Use `findIp` instead.