chore: only prevent interval be undefined

Author: bjohansebas

lib/Server.js

@@ -306,22 +306,6 @@ function useFn(route, fn) {
 
 const DEFAULT_ALLOWED_PROTOCOLS = /^(file|.+-extension):/i;
 
-/**
- * Removes properties with undefined values from an object.
- * Needed because chokidar v4 crashes when options are explicitly set to undefined.
- * @see https://github.com/paulmillr/chokidar/issues/1394
- * @template {Record<string, unknown>} T
- * @param {T} obj the object to filter
- * @returns {T} a new object without undefined values
- */
-function removeUndefinedValues(obj) {
-  return /** @type {T} */ (
-    Object.fromEntries(
-      Object.entries(obj).filter(([, value]) => typeof value !== "undefined"),
-    )
-  );
-}
-
 /**
  * @typedef {object} BasicApplication
  * @property {typeof useFn} use
@@ -849,7 +833,7 @@ class Server {
 
       const usePolling = getPolling();
       const interval = getInterval();
-      const { poll: _poll, ...rest } = watchOptions;
+      const { poll: _poll, interval: _interval, ...rest } = watchOptions;
 
       return {
         ignoreInitial: true,
@@ -3205,11 +3189,7 @@ class Server {
   watchFiles(watchPath, watchOptions = {}) {
     const chokidar = require("chokidar");
 
-    // https://github.com/paulmillr/chokidar/issues/1394
-    const watcher = chokidar.watch(
-      watchPath,
-      removeUndefinedValues(watchOptions),
-    );
+    const watcher = chokidar.watch(watchPath, watchOptions);
 
     // disabling refreshing on changing the content
     if (this.options.liveReload) {

test/cli/__snapshots__/basic.test.js.snap.webpack5

@@ -126,8 +126,8 @@ Options:
   --no-static-watch                                   Does not watch for files in static content directory.
   --static-reset                                      Clear all items provided in 'static' configuration. Allows to configure options for serving static files from directory (by default 'public' directory).
   --static-public-path-reset                          Clear all items provided in 'static.publicPath' configuration. The static files will be available in the browser under this public path.
-  --watch-files <value...>                            Allows to configure list of globs/directories/files to watch for file changes.
-  --watch-files-reset                                 Clear all items provided in 'watchFiles' configuration. Allows to configure list of globs/directories/files to watch for file changes.
+  --watch-files <value...>                            Allows to configure list of directories/files to watch for file changes.
+  --watch-files-reset                                 Clear all items provided in 'watchFiles' configuration. Allows to configure list of directories/files to watch for file changes.
   --no-web-socket-server                              Disallows to set web socket server and options.
   --web-socket-server-type <value>                    Allows to set web socket server and options (by default 'ws').
 

test/e2e/__snapshots__/watch-files.test.js.snap.webpack5

@@ -365,7 +365,7 @@ exports[`watchFiles option should work with options {} should reload when file c
   "ignorePermissionErrors": true,
   "ignored": [],
   "interval": 100,
-  "persistent": true,
+  "persistent": undefined,
   "usePolling": true,
 }
 `;
@@ -376,7 +376,7 @@ exports[`watchFiles option should work with options {} should reload when file c
   "atomic": false,
   "awaitWriteFinish": false,
   "binaryInterval": 300,
-  "followSymlinks": true,
+  "followSymlinks": undefined,
   "ignoreInitial": true,
   "ignorePermissionErrors": true,
   "ignored": [],
@@ -404,6 +404,7 @@ exports[`watchFiles option should work with options {} should reload when file c
 
 exports[`watchFiles option should work with options {} should reload when file content is changed 6`] = `
 {
+  "alwaysStat": undefined,
   "atomic": false,
   "awaitWriteFinish": false,
   "binaryInterval": 300,
@@ -423,6 +424,7 @@ exports[`watchFiles option should work with options {} should reload when file c
   "atomic": false,
   "awaitWriteFinish": false,
   "binaryInterval": 300,
+  "depth": undefined,
   "followSymlinks": false,
   "ignoreInitial": true,
   "ignorePermissionErrors": true,
@@ -441,7 +443,7 @@ exports[`watchFiles option should work with options {} should reload when file c
   "binaryInterval": 300,
   "followSymlinks": false,
   "ignoreInitial": true,
-  "ignorePermissionErrors": false,
+  "ignorePermissionErrors": undefined,
   "ignored": [],
   "interval": 100,
   "persistent": true,