Skip to content

Commit 22125dc

Browse files
fix: add dark variant for placeholder (#8160)
1 parent c961dc2 commit 22125dc

File tree

3 files changed

+21
-30
lines changed

3 files changed

+21
-30
lines changed

src/components/Placeholder/Placeholder.jsx

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,34 @@
11
// Placeholder string
22
const placeholderString = () => `
33
<div class="placeholder">
4-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
5-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
6-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
7-
<h2 class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</h2>
8-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
9-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
10-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
11-
<h2 class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</h2>
12-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
13-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
14-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</p>
15-
<h2 class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</h2>
16-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
17-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
18-
<p class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
4+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
5+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
6+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
7+
<h2 class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</h2>
8+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
9+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
10+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
11+
<h2 class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</h2>
12+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
13+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
14+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</p>
15+
<h2 class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[35%]">&nbsp;</h2>
16+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]">&nbsp;</p>
17+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2">&nbsp;</p>
18+
<p class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4">&nbsp;</p>
1919
</div>
2020
`;
2121

2222
function PlaceholderComponent() {
2323
return (
2424
<div className="placeholder">
25-
<p className="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4">
25+
<p className="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4">
2626
&nbsp;
2727
</p>
28-
<p className="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]">
28+
<p className="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]">
2929
&nbsp;
3030
</p>
31-
<p className="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2">
31+
<p className="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2">
3232
&nbsp;
3333
</p>
3434
</div>

src/components/Placeholder/__snapshots__/Placeholder.test.jsx.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ exports[`PlaceholderComponent renders correctly 1`] = `
55
class="placeholder"
66
>
77
<p
8-
class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-3/4"
8+
class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-3/4"
99
>
1010
 
1111
</p>
1212
<p
13-
class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-[85%]"
13+
class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-[85%]"
1414
>
1515
 
1616
</p>
1717
<p
18-
class="bg-gray-100 font-sans overflow-hidden relative animate-pulse w-1/2"
18+
class="bg-gray-100 dark:bg-gray-800 font-sans overflow-hidden relative animate-pulse w-1/2"
1919
>
2020
 
2121
</p>

src/styles/dark.css

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -118,15 +118,6 @@
118118
@apply bg-[#121212] text-[#9ab3c0];
119119
}
120120

121-
.placeholder h2,
122-
.placeholder p {
123-
@apply bg-[#252525];
124-
125-
&:after {
126-
background: linear-gradient(90deg, #252525, #121212, #252525);
127-
}
128-
}
129-
130121
.footer-openjsf-logo {
131122
@apply invert;
132123
}

0 commit comments

Comments
 (0)