Skip to content

Fix service worker installation failure on Firefox #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranjalisr wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix service worker installation failure on Firefox #7755

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9196cdd
fix(sw): prevent Firefox install failure on precache errors
pranjalisr Jan 20, 2026
670d441
fix(sw): prevent Firefox install failure on precache errors
pranjalisr Jan 20, 2026
4b91860
fix: satisfy arrow-body-style lint rule
pranjalisr Jan 20, 2026
c72b3a5
fix: conform to arrow-body-style in activate handler
pranjalisr Jan 20, 2026
f5e7e04
Re-added comments
pranjalisr Feb 9, 2026
9bfa412
updated indendation
pranjalisr Feb 9, 2026
4fe19fc
fixed comments
pranjalisr Feb 11, 2026
574e27c
made changes
pranjalisr Mar 28, 2026
25da846
restored icon
pranjalisr Mar 29, 2026
a5e552a
Fix service worker
pranjalisr Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Site/Site.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ function Site(props) {
/>
<meta name="mobile-web-app-capable" content="yes" />
<link rel="icon" sizes="192x192" href="/icon_192x192.png" />
<link rel="icon" sizes="512x512" href="/icon_512x512.png" />
Copy link
Copy Markdown
Member

@evenstensberg evenstensberg Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont remove

Copy link
Copy Markdown
Contributor Author

@pranjalisr pranjalisr Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it's causing error in network tab

Screenshot 2026-03-29 at 00 44 00

Copy link
Copy Markdown
Member

@evenstensberg evenstensberg Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means that its missing in our dist folder, we need to add it back.

Copy link
Copy Markdown
Contributor Author

@pranjalisr pranjalisr Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored the icon. Running fine locally, please review
Screenshot 2026-03-29 at 15 05 25

<meta name="apple-mobile-web-app-capable" content="yes" />
<meta name="apple-mobile-web-app-status-bar-style" content="black" />
<meta name="apple-mobile-web-app-title" content="webpack" />
Expand Down
28 changes: 15 additions & 13 deletions src/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
NetworkOnly,
StaleWhileRevalidate,
} from "workbox-strategies";
/* eslint-enable import/no-extraneous-dependencies */

const cacheName = cacheNames.runtime;

Expand All @@ -25,16 +24,23 @@ const otherManifest = [
url: "/app-shell/index.html",
},
];
const manifestURLs = [...manifest, ...otherManifest].map((entry) => {
const url = new URL(entry.url, self.location);
return url.href;
});
const manifestURLs = [
...new Set(
[...manifest, ...otherManifest].map((entry) => {
const url = new URL(entry.url, self.location);
return url.href;
}),
),
];
self.addEventListener("install", (event) => {
event.waitUntil(
Comment thread
ovflowd marked this conversation as resolved.
caches.open(cacheName).then((cache) => cache.addAll(manifestURLs)),
(async () => {
const cache = await caches.open(cacheName);

await Promise.allSettled(manifestURLs.map((url) => cache.add(url)));
})(),
Comment thread
ovflowd marked this conversation as resolved.
);
});

self.addEventListener("activate", (event) => {
// - [x] clean up outdated runtime cache
event.waitUntil(
Expand All @@ -52,7 +58,6 @@ self.addEventListener("activate", (event) => {
),
);
});

registerRoute(
({ url }) => manifestURLs.includes(url.href),
new NetworkFirst({
Expand Down Expand Up @@ -83,10 +88,7 @@ setDefaultHandler(new NetworkOnly());

// fallback to app-shell for document request
setCatchHandler(({ event }) => {
switch (event.request.destination) {
case "document":
return caches.match("/app-shell/index.html");
default:
return Response.error();
Copy link
Copy Markdown
Member

@evenstensberg evenstensberg Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont remove the error handling please

if (event.request.destination === "document") {
return caches.match("/app-shell/index.html");
}
});
Loading