Skip to content

fix(a11y): use distinct alt text for footer license icons#7971

Merged
alexander-akait merged 8 commits into
webpack:mainfrom
mr-baraiya:fix-footer-license-a11y
Mar 11, 2026
Merged

fix(a11y): use distinct alt text for footer license icons#7971
alexander-akait merged 8 commits into
webpack:mainfrom
mr-baraiya:fix-footer-license-a11y

Conversation

@mr-baraiya
Copy link
Copy Markdown
Contributor

@mr-baraiya mr-baraiya commented Mar 10, 2026

Fixes #7970

The footer license link contained two images with identical alt text
("Creative Commons License").

Screen readers may announce duplicated text.

This change provides distinct alt text for each Creative Commons icon
to avoid duplicate announcements by screen readers.

Copilot AI review requested due to automatic review settings March 10, 2026 13:34
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-js-org Ready Ready Preview, Comment Mar 11, 2026 5:52pm

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves footer accessibility by preventing screen readers from announcing duplicate alternative text for the Creative Commons license icons, aligning with issue #7970.

Changes:

  • Adds an aria-label to the /license footer link to provide a single accessible name.
  • Marks the two license icon images as decorative by setting alt="".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Copy Markdown
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just add different alt for them

@mr-baraiya mr-baraiya changed the title fix(a11y): remove duplicate alt text from footer license icons fix(a11y): use distinct alt text for footer license icons Mar 10, 2026
@mr-baraiya
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback! I’ve updated the footer icons to use distinct alt text for each image.

src={BY}
width={25}
height={25}
/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Creative Commons License (CC) and Creative Commons Attribution (CC BY)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the footer icons with the requested alt text:

  • Creative Commons License (CC)
  • Creative Commons Attribution (CC BY)

Please let me know if anything else needs adjustment.

@alexander-akait alexander-akait merged commit eecd841 into webpack:main Mar 11, 2026
8 of 9 checks passed
@mr-baraiya mr-baraiya deleted the fix-footer-license-a11y branch March 12, 2026 04:31
pranjalisr pushed a commit to pranjalisr/webpack.js.org that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate screen reader text in footer license link

3 participants