Skip to content

fix(Page): disconnect MutationObserver after hash target is found #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 7 commits into from
Mar 14, 2026
Merged

fix(Page): disconnect MutationObserver after hash target is found #8007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
493d643
fix(Page): disconnect MutationObserver after hash target is found
mr-baraiya Mar 13, 2026
d8f01e0
test(Page): add Cypress test for hash navigation behavior
mr-baraiya Mar 13, 2026
4e96d08
style: apply formatting fixes
mr-baraiya Mar 13, 2026
e7d2ac4
style(test): add use strict for eslint rule
mr-baraiya Mar 13, 2026
ee41c2e
test(Page): stabilize Cypress hash navigation test
mr-baraiya Mar 14, 2026
277f991
test(Page): make Cypress hash navigation test more stable
mr-baraiya Mar 14, 2026
15322e6
test(Page): add real Cypress test for hash navigation
mr-baraiya Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions cypress/e2e/page-hash-navigation.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
"use strict";

describe("Page hash navigation", () => {
it("scrolls to the element specified by the hash", () => {
cy.visit("/guides/getting-started/#basic-setup");

cy.location("hash").should("eq", "#basic-setup");

cy.get("#basic-setup", { timeout: 10000 })
.should("exist")
.then(($el) => {
const rect = $el[0].getBoundingClientRect();
expect(rect.top).to.be.lessThan(200);
});
});
});
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the useful test - you test nothing here

1 change: 1 addition & 0 deletions src/components/Page/Page.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export default function Page(props) {
const element = document.getElementById(hash.slice(1));
if (element) {
element.scrollIntoView();
observer.disconnect();
}
});
observer.observe(target, {
Expand Down
Loading