refactor: replace deprecated url.resolve() with WHATWG URL API#8183
Open
ryzrr wants to merge 1 commit intowebpack:mainfrom
Open
refactor: replace deprecated url.resolve() with WHATWG URL API#8183ryzrr wants to merge 1 commit intowebpack:mainfrom
ryzrr wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated Node.js url.resolve() calls with the modern WHATWG URL API (new URL()) in PageLinks.jsx and process-readme.mjs. This also removes two eslint-disable comments and an unused import that were only there to suppress the deprecation warnings.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No, but existing tests cover both files and were verified to still pass.
Does this PR introduce a breaking change?
No. Both base URLs are always absolute https:// strings, so the stricter new URL() constructor is safe to use here.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing needs to be documented.
Use of AI?
No