Skip to content

refactor: replace deprecated url.resolve() with WHATWG URL API #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 1 commit into from
Apr 12, 2026
+2 −7
Merged

refactor: replace deprecated url.resolve() with WHATWG URL API #8183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/components/PageLinks/PageLinks.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// eslint-disable-next-line n/prefer-node-protocol
import Url from "url";
import PropTypes from "prop-types";

const baseURL = "https://github.com/webpack/webpack.js.org/edit/main/";
Expand All @@ -21,8 +19,7 @@ function _handlePrintClick(event) {
}

export default function PageLinks({ page = {} }) {
// eslint-disable-next-line n/no-deprecated-api
const editLink = page.edit || Url.resolve(baseURL, page.path);
const editLink = page.edit || new URL(page.path, baseURL).href;

return (
<div className="print:hidden mt-8">
Expand Down
4 changes: 1 addition & 3 deletions src/utilities/process-readme.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import url from "node:url";
import { excludedLoaders, excludedPlugins } from "./constants.mjs";

const beginsWithDocsDomainRegex = /^(?:https?:)\/\/webpack\.js\.org/;
Expand Down Expand Up @@ -40,8 +39,7 @@ function linkFixerFactory(sourceUrl) {
.replace(/raw.githubusercontent.com/, "github.com")
.replace(/master/, "blob/master");

// eslint-disable-next-line n/no-deprecated-api
href = url.resolve(renderedUrl, href);
href = new URL(href, renderedUrl).href;
}

// Modify absolute documentation links to be root relative
Expand Down
Loading