Fix source audit issues in content utilities and sidebar#8200
Closed
arechaithanya wants to merge 1 commit intowebpack:mainfrom
Closed
Fix source audit issues in content utilities and sidebar#8200arechaithanya wants to merge 1 commit intowebpack:mainfrom
arechaithanya wants to merge 1 commit intowebpack:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks like AI generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several correctness issues found during an audit of /src.
Changes include:
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes. I added regression coverage for:
Validated with:
npm run jest -- src/components/SidebarItem/SidebarItem.test.jsx src/utilities/content-tree-enhancers.test.mjs src/utilities/process-readme.test.mjs src/utilities/content-utils.test.mjs
npm run lint:js -- src/components/SidebarItem/SidebarItem.jsx src/components/SidebarItem/SidebarItem.test.jsx src/remark-plugins/remark-refractor/index.mjs src/utilities/content-tree-enhancers.mjs src/utilities/content-tree-enhancers.test.mjs src/utilities/content-utils.mjs src/utilities/flatten-content-tree.mjs src/utilities/process-readme.mjs src/utilities/process-readme.test.mjs
npx prettier --check src/components/SidebarItem/SidebarItem.jsx src/components/SidebarItem/SidebarItem.test.jsx src/remark-plugins/remark-refractor/index.mjs src/utilities/content-tree-enhancers.mjs src/utilities/content-tree-enhancers.test.mjs src/utilities/content-utils.mjs src/utilities/flatten-content-tree.mjs src/utilities/process-readme.mjs src/utilities/process-readme.test.mjs
git diff --check
The repository pre-commit hook also passed.
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No documentation changes are required. These are internal source fixes.
Use of AI
I used AI assistance to audit the source files, identify fragile logic, draft the fixes, and prepare regression tests. I reviewed the changes and validated them with the repository’s test, lint, and formatting checks before pushing.