Skip to content

Commit f8bd4e5

Browse files
ikreymeremma-sg
authored andcommitted
only do raw text compare for 200 status code pages
1 parent e6bf4ee commit f8bd4e5

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

src/replaycrawler.ts

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,11 +524,13 @@ export class ReplayCrawler extends Crawler {
524524

525525
await this.compareText(page, data, url, date);
526526

527-
await this.compareRawText(page, data, url, date);
527+
await this.compareResources(page, data, url, date);
528528

529-
await this.writeHtmlToWarc(page, url, date, data.originalWarcRecordId);
529+
if (data.doRawTextCompare) {
530+
await this.compareRawText(page, data, url, date);
530531

531-
await this.compareResources(page, data, url, date);
532+
await this.writeHtmlToWarc(page, url, date, data.originalWarcRecordId);
533+
}
532534

533535
if (this.params.qaDetectClientSideRendering)
534536
await this.processCSRClues(page, data);
@@ -871,6 +873,14 @@ export class ReplayCrawler extends Crawler {
871873
pageInfo.ts = origResData.ts;
872874
}
873875

876+
logger.info("Page Resource Status", {
877+
status: origResData.urls[origResData.url]?.status,
878+
});
879+
880+
if (origResData.url && origResData.urls[origResData.url].status === 200) {
881+
state.doRawTextCompare = true;
882+
}
883+
874884
const { resourceCounts } = pageInfo.comparison;
875885

876886
const { good: crawlGood, bad: crawlBad } = this.countResources(origResData);

src/util/state.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export class PageState {
9595
isHTMLPage = true;
9696
text?: string;
9797
originalText?: string;
98+
doRawTextCompare?: boolean;
9899
textFromResponse?: string;
99100
documentRequestId?: string;
100101
screenshotView?: Buffer;

0 commit comments

Comments
 (0)