chore: lower asset limit log level

Author: kof

apps/builder/app/routes/rest.assets.test.ts

@@ -0,0 +1,67 @@
+import { afterEach, describe, expect, test, vi } from "vitest";
+
+const createUploadName = vi.hoisted(() => vi.fn());
+const createContext = vi.hoisted(() => vi.fn());
+const preventCrossOriginCookie = vi.hoisted(() => vi.fn());
+const checkCsrf = vi.hoisted(() => vi.fn());
+
+vi.mock("@webstudio-is/asset-uploader/index.server", () => ({
+  createUploadName,
+  loadAssetsByProject: vi.fn(),
+}));
+
+vi.mock("~/shared/context.server", () => ({
+  createContext,
+}));
+
+vi.mock("~/services/no-cross-origin-cookie", () => ({
+  preventCrossOriginCookie,
+}));
+
+vi.mock("~/services/csrf-session.server", () => ({
+  checkCsrf,
+}));
+
+import { action } from "./rest.assets";
+
+describe("rest.assets action", () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+    vi.clearAllMocks();
+  });
+
+  test("logs asset limit errors as info", async () => {
+    const consoleError = vi
+      .spyOn(console, "error")
+      .mockImplementation(() => {});
+    const consoleInfo = vi.spyOn(console, "info").mockImplementation(() => {});
+    const error = new Error("The maximum number of assets per project is 100.");
+    createContext.mockResolvedValue({
+      planFeatures: {
+        maxAssetsPerProject: 100,
+      },
+    });
+    createUploadName.mockRejectedValue(error);
+    const formData = new FormData();
+    formData.set("assetId", "asset-id");
+    formData.set("projectId", "project-id");
+    formData.set("type", "image/png");
+    formData.set("filename", "image.png");
+    const request = new Request("https://apps.webstudio.is/rest/assets", {
+      method: "POST",
+      body: formData,
+    });
+
+    await expect(
+      action({
+        request,
+        params: {},
+        context: {},
+      })
+    ).resolves.toEqual({
+      errors: "The maximum number of assets per project is 100.",
+    });
+    expect(consoleError).not.toHaveBeenCalled();
+    expect(consoleInfo).toHaveBeenCalledWith(error);
+  });
+});

apps/builder/app/routes/rest.assets.tsx

@@ -12,6 +12,8 @@ import { preventCrossOriginCookie } from "~/services/no-cross-origin-cookie";
 import { checkCsrf } from "~/services/csrf-session.server";
 import { parseError } from "~/shared/error/error-parse";
 
+const maxAssetsErrorPrefix = "The maximum number of assets per project is ";
+
 export const loader = async ({
   params,
   request,
@@ -61,10 +63,16 @@ export const action = async (props: ActionFunctionArgs) => {
       };
     }
   } catch (error) {
-    console.error(error);
+    const parsedError = parseError(error);
+
+    if (parsedError.message.startsWith(maxAssetsErrorPrefix)) {
+      console.info(error);
+    } else {
+      console.error(error);
+    }
 
     return {
-      errors: parseError(error).message,
+      errors: parsedError.message,
     };
   }
 };