Skip to content

Commit 33f3e0c

Browse files
committed
chore: lower cross-origin block log level
1 parent 6b09e91 commit 33f3e0c

2 files changed

Lines changed: 31 additions & 1 deletion

File tree

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import { afterEach, describe, expect, test, vi } from "vitest";
2+
import { preventCrossOriginCookie } from "./no-cross-origin-cookie";
3+
4+
describe("preventCrossOriginCookie", () => {
5+
afterEach(() => {
6+
vi.restoreAllMocks();
7+
});
8+
9+
test("logs blocked cross-origin requests as info", () => {
10+
const consoleError = vi
11+
.spyOn(console, "error")
12+
.mockImplementation(() => {});
13+
const consoleInfo = vi.spyOn(console, "info").mockImplementation(() => {});
14+
const request = new Request("https://apps.webstudio.is/rest/data", {
15+
method: "POST",
16+
headers: {
17+
cookie: "session=1",
18+
},
19+
});
20+
21+
expect(() => preventCrossOriginCookie(request)).toThrow();
22+
23+
expect(consoleError).not.toHaveBeenCalled();
24+
expect(consoleInfo).toHaveBeenCalledWith(
25+
"Blocked cross-origin request to https://apps.webstudio.is/rest/data",
26+
[]
27+
);
28+
expect(request.headers.has("cookie")).toBe(false);
29+
});
30+
});

apps/builder/app/services/no-cross-origin-cookie.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const preventCrossOriginCookie = (
4141
}
4242

4343
if (throwError) {
44-
console.error(`Cross-origin request to ${request.url} blocked`, [
44+
console.info(`Blocked cross-origin request to ${request.url}`, [
4545
...request.headers.entries(),
4646
]);
4747

0 commit comments

Comments
 (0)