chore: handle asset limit as expected error

Author: kof

apps/builder/app/routes/rest.assets.test.ts

@@ -0,0 +1,10 @@
+import { describe, expect, test } from "vitest";
+import { MaxAssetsPerProjectError } from "@webstudio-is/asset-uploader/index.server";
+
+describe("MaxAssetsPerProjectError", () => {
+  test("can be classified by type", () => {
+    expect(new MaxAssetsPerProjectError(100)).toBeInstanceOf(
+      MaxAssetsPerProjectError
+    );
+  });
+});

apps/builder/app/routes/rest.assets.tsx

@@ -6,6 +6,7 @@ import type { Asset } from "@webstudio-is/sdk";
 import {
   loadAssetsByProject,
   createUploadName,
+  MaxAssetsPerProjectError,
 } from "@webstudio-is/asset-uploader/index.server";
 import { createContext } from "~/shared/context.server";
 import { preventCrossOriginCookie } from "~/services/no-cross-origin-cookie";
@@ -61,10 +62,16 @@ export const action = async (props: ActionFunctionArgs) => {
       };
     }
   } catch (error) {
-    console.error(error);
+    const parsedError = parseError(error);
+
+    if (error instanceof MaxAssetsPerProjectError) {
+      console.info(error);
+    } else {
+      console.error(error);
+    }
 
     return {
-      errors: parseError(error).message,
+      errors: parsedError.message,
     };
   }
 };

packages/asset-uploader/src/schema.ts

@@ -11,9 +11,3 @@ export const MaxSize: z.ZodEffects<
   .default(MAX_UPLOAD_SIZE)
   // user inputs the max value in mb and we transform it to bytes
   .transform(toBytes);
-
-export const MaxAssets: z.ZodEffects<
-  z.ZodDefault<z.ZodString>,
-  number,
-  string | undefined
-> = z.string().default("100").transform(Number.parseFloat);

packages/asset-uploader/src/upload.ts

@@ -17,6 +17,15 @@ type UploadData = {
   maxAssetsPerProject: number;
 };
 
+export class MaxAssetsPerProjectError extends Error {
+  constructor(maxAssetsPerProject: number) {
+    super(
+      `The maximum number of assets per project is ${maxAssetsPerProject}.`
+    );
+    this.name = "MaxAssetsPerProjectError";
+  }
+}
+
 const UPLOADING_STALE_TIMEOUT = 1000 * 60 * 30; // 30 minutes
 
 export const createUploadName = async (
@@ -65,9 +74,7 @@ export const createUploadName = async (
      * it's probable that the user can exceed the limit a little bit.
      * So it can be a little bit strange that the limit is 5 but the user already has 7.
      **/
-    throw new Error(
-      `The maximum number of assets per project is ${maxAssetsPerProject}.`
-    );
+    throw new MaxAssetsPerProjectError(maxAssetsPerProject);
   }
 
   /**