Skip to content

experimental: Animation polyfill, fix parsing of wrong unit values, fix position sticky#5116

Merged
istarkov merged 2 commits into
mainfrom
polyfill.staging
Apr 10, 2025
Merged

experimental: Animation polyfill, fix parsing of wrong unit values, fix position sticky#5116
istarkov merged 2 commits into
mainfrom
polyfill.staging

Conversation

@istarkov
Copy link
Copy Markdown
Contributor

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov marked this pull request as ready for review April 10, 2025 17:11
@istarkov istarkov merged commit 2366abe into main Apr 10, 2025
29 checks passed
@istarkov istarkov deleted the polyfill.staging branch April 10, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant