fix: handle autoplay property in youtube and vimeo#5211
Closed
TrySound wants to merge 1 commit into
Closed
Conversation
We have issue with distincting html attributes and component properties. I have an idea for proper fix. For now fast fix with just aliasing autoplay and autoPlay.
kof
approved these changes
May 16, 2025
TrySound
added a commit
that referenced
this pull request
May 16, 2025
Related #5211 We moved html attributes away from props metas and have very little actual props left in meta. It is safe to merge with component meta to simplify access in both builder and CLI. CLI size increase is not very significant ```diff - 241.92kB + 256.64kB ```
TrySound
added a commit
that referenced
this pull request
May 16, 2025
Related #5211 We moved html attributes away from props metas and have very little actual props left in meta. It is safe to merge with component meta to simplify access in both builder and CLI. CLI size increase is not very significant ```diff - 241.92kB + 256.64kB ```
TrySound
added a commit
that referenced
this pull request
May 16, 2025
TrySound
added a commit
that referenced
this pull request
May 16, 2025
TrySound
added a commit
that referenced
this pull request
May 17, 2025
) Proper fix for #5211 Now props meta are available in component generator and can be used to figure if prop is defined by component or comes from html attributes. Added same logic in canvas and component generator. Also got rid from no longer necessary registeredComponentPropsMetas store since all props are described by component meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have issue with distincting html attributes and component properties. I have an idea for proper fix. For now fast fix with just aliasing autoplay and autoPlay.