Skip to content

chore: Pages.staging#5736

Merged
kof merged 9 commits intomainfrom
pages.staging
Apr 28, 2026
Merged

chore: Pages.staging#5736
kof merged 9 commits intomainfrom
pages.staging

Conversation

@kof
Copy link
Copy Markdown
Member

@kof kof commented Apr 28, 2026

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

kof added 8 commits April 28, 2026 10:49
@kof
Inject public collab relay URL during Vercel build
1527078
@kof
Fix page patch denormalization
2611411
@kof
Pass collab relay URL into Vercel action
21b33d0
@kof
Fix page patch normalization coverage
8aa8c43
@kof
Migrate pages to id-keyed maps
8210ded
@kof
Update pnpm-lock.yaml
4b6d9f0
@kof
Use Maps for Pages in props tests
e6e1bbb 
Update tests to match the new Pages shape that uses Maps and id fields. Replace the old pages/folders arrays with pagesBase exposing homePageId/rootFolderId and Map-based pages/folders, add a createPages helper and rootFolder constant, and update tests to call createPages where pages/folders are constructed.
@kof
Move build data sync to tRPC
bd7b6ee
@kof kof force-pushed the pages.staging branch 2 times, most recently from 1c355a3 to 7b92184 Compare April 28, 2026 17:32
@kof kof merged commit 9ea5f70 into main Apr 28, 2026
32 of 34 checks passed
@kof kof deleted the pages.staging branch April 28, 2026 17:43
@xanderio
Copy link
Copy Markdown

xanderio commented Apr 29, 2026

@kof This PR introduced a breaking change to the CLI API endpoints, this make the CLI completely unusable. Could we get a new release on NPM, as this appears to be already deployed on production?

2026-04-29T10:27:57.488654Z 01O ◒  Synchronizing project data from https://apps.webstudio.is/...
2026-04-29T10:27:57.812248Z 01O ▲  <!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1"/><link rel="modulepreload" href="/assets/manifest-21e1791b.js"/><link rel="modulepreload" href="/assets/entry.client-DhzXtudQ.js"/><link rel="modulepreload" href="/assets/index-BgCmmWrb.js"/><link rel="modulepreload" href="/assets/index-DFvtkpEA.js"/><link rel="modulepreload" href="/assets/components-Bzjd5jQd.js"/><link rel="modulepreload" href="/assets/feature-CfAzabit.js"/><link rel="modulepreload" href="/assets/root-DoMsVsbf.js"/><link rel="modulepreload" href="/assets/error-boundary-DzhnLvok.js"/><link rel="modulepreload" href="/assets/tiny-invariant-CopsF_GD.js"/><link rel="modulepreload" href="/assets/csrf.client-ObEIYQRT.js"/><link rel="modulepreload" href="/assets/scroll-restoration-zsKoAte2.js"/><link rel="modulepreload" href="/assets/_ui-CUof9mI_.js"/><link rel="modulepreload" href="/assets/_ui._-BeBsEV-Z.js"/><link rel="stylesheet" href="/assets/ind
2026-04-29T10:27:57.814656Z 01E Error: <!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1"/><link rel="modulepreload" href="/assets/manifest-21e1791b.js"/><link rel="modulepreload" href="/assets/entry.client-DhzXtudQ.js"/><link rel="modulepreload" href="/assets/index-BgCmmWrb.js"/><link rel="modulepreload" href="/assets/index-DFvtkpEA.js"/><link rel="modulepreload" href="/assets/components-Bzjd5jQd.js"/><link rel="modulepreload" href="/assets/feature-CfAzabit.js"/><link rel="modulepreload" href="/assets/root-DoMsVsbf.js"/><link rel="modulepreload" href="/assets/error-boundary-DzhnLvok.js"/><link rel="modulepreload" href="/assets/tiny-invariant-CopsF_GD.js"/><link rel="modulepreload" href="/assets/csrf.client-ObEIYQRT.js"/><link rel="modulepreload" href="/assets/scroll-restoration-zsKoAte2.js"/><link rel="modulepreload" href="/assets/_ui-CUof9mI_.js"/><link rel="modulepreload" href="/assets/_ui._-BeBsEV-Z.js"/><link rel="stylesheet" href="/assets/ind
2026-04-29T10:27:57.814671Z 01E     at getLatestBuildUsingProjectId (file:///var/lib/gitlab-runner/builds/XzQvVPjaD/0/cyberus/infrastructure/homepage-webstudio/node_modules/webstudio/lib/cli.js:159:9)
2026-04-29T10:27:57.814675Z 01E     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
2026-04-29T10:27:57.814677Z 01E     at async loadProjectDataByProjectId (file:///var/lib/gitlab-runner/builds/XzQvVPjaD/0/cyberus/infrastructure/homepage-webstudio/node_modules/webstudio/lib/cli.js:181:18)
2026-04-29T10:27:57.814680Z 01E     at async Object.sync [as handler] (file:///var/lib/gitlab-runner/builds/XzQvVPjaD/0/cyberus/infrastructure/homepage-webstudio/node_modules/webstudio/lib/cli.js:348:12)

@kof
Copy link
Copy Markdown
Member Author

kof commented Apr 29, 2026

@xanderio I thought I released the CLI, did I not? what's your webstudio --version saying?

@xanderio
Copy link
Copy Markdown

xanderio commented Apr 29, 2026

Version 0.265.0 has been published to NPM one hour ago.

@kof
Copy link
Copy Markdown
Member Author

kof commented Apr 29, 2026

@xanderio so does this fix the problem you are seeing?

@xanderio
Copy link
Copy Markdown

xanderio commented Apr 29, 2026

Yes that did fix the issue.

@xanderio
Copy link
Copy Markdown

xanderio commented Apr 29, 2026

@kof While the CLI issue is fixed, I'm unable to build the site do to a dependency resolution error that is also cased by this PR.

npm error code ETARGET
npm error notarget No matching version found for @webstudio-is/css-data@0.0.0.
npm error notarget In most cases you or one of your dependencies are requesting a package version that doesn't exist.

@kof
Copy link
Copy Markdown
Member Author

kof commented Apr 29, 2026

You get that running which command?

@xanderio
Copy link
Copy Markdown

xanderio commented Apr 29, 2026

npm install

@kof
Copy link
Copy Markdown
Member Author

kof commented Apr 29, 2026

0.266.0 is released, please check now after updating the cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kof @xanderio