Fix cargo fmt and cargo clippy pass

AlbertShown · AlbertShown · commit ef9a83d948be · 2026-03-23T18:19:59.000-04:00
diff --git a/build.rs b/build.rs
@@ -23,7 +23,10 @@ fn main() {
             "https://github.com/webui-dev/webui/releases/download/nightly/{}.zip",
             zip_name
         );
-        println!("cargo:warning=WebUI library not found. Downloading: {}", url);
+        println!(
+            "cargo:warning=WebUI library not found. Downloading: {}",
+            url
+        );
         fetch_library(&url, &zip_name, lib_filename, &manifest_dir);
         println!("cargo:warning=WebUI library ready.");
     }
@@ -78,12 +81,7 @@ fn fetch_library(url: &str, zip_name: &str, lib_filename: &str, dest_dir: &str)
             ),
         ]));
     } else {
-        run(Command::new("curl").args([
-            "-fsSL",
-            "-o",
-            zip_path.to_str().unwrap(),
-            url,
-        ]));
+        run(Command::new("curl").args(["-fsSL", "-o", zip_path.to_str().unwrap(), url]));
     }
 
     // Extract
@@ -99,13 +97,7 @@ fn fetch_library(url: &str, zip_name: &str, lib_filename: &str, dest_dir: &str)
             ),
         ]));
     } else {
-        run(Command::new("unzip").args([
-            "-q",
-            "-o",
-            zip_path.to_str().unwrap(),
-            "-d",
-            dest_dir,
-        ]));
+        run(Command::new("unzip").args(["-q", "-o", zip_path.to_str().unwrap(), "-d", dest_dir]));
     }
 
     // Copy static lib to project root
diff --git a/examples/call_js_from_rust/main.rs b/examples/call_js_from_rust/main.rs
@@ -97,7 +97,7 @@ fn my_function_count(e: webui::Event) {
 
     // Run JS without capturing return value (faster)
     // No buffer needed since this is a fire and forget call.
-    window.run(&format!("SetCount({next});"));
+    window.run(format!("SetCount({next});"));
 }
 
 fn main() {
diff --git a/examples/call_rust_from_js/main.rs b/examples/call_rust_from_js/main.rs
@@ -68,23 +68,23 @@ const HTML: &str = r#"<!DOCTYPE html>
 
 fn my_function_string(e: webui::Event) {
     // JavaScript: my_function_string('Hello', 'World')
-    println!("my_function_string 1: {}", e.get_string());    // Hello
+    println!("my_function_string 1: {}", e.get_string()); // Hello
     println!("my_function_string 2: {}", e.get_string_at(1)); // World
 }
 
 fn my_function_integer(e: webui::Event) {
     // JavaScript: my_function_integer(123, 456, 789, 12345.6789)
     println!("my_function_integer: {} arguments", e.get_count());
-    println!("my_function_integer 1: {}", e.get_int());        // 123
-    println!("my_function_integer 2: {}", e.get_int_at(1));    // 456
-    println!("my_function_integer 3: {}", e.get_int_at(2));    // 789
-    println!("my_function_integer 4: {}", e.get_float_at(3));  // 12345.6789
+    println!("my_function_integer 1: {}", e.get_int()); // 123
+    println!("my_function_integer 2: {}", e.get_int_at(1)); // 456
+    println!("my_function_integer 3: {}", e.get_int_at(2)); // 789
+    println!("my_function_integer 4: {}", e.get_float_at(3)); // 12345.6789
 }
 
 fn my_function_boolean(e: webui::Event) {
     // JavaScript: my_function_boolean(true, false)
-    println!("my_function_boolean 1: {}", e.get_bool());       // true
-    println!("my_function_boolean 2: {}", e.get_bool_at(1));   // false
+    println!("my_function_boolean 1: {}", e.get_bool()); // true
+    println!("my_function_boolean 2: {}", e.get_bool_at(1)); // false
 }
 
 fn my_function_raw_binary(e: webui::Event) {
@@ -99,7 +99,10 @@ fn my_function_raw_binary(e: webui::Event) {
     println!();
 
     let valid = bytes2.first() == Some(&0xA1) && bytes2.last() == Some(&0xA2);
-    println!("my_function_raw_binary 2 big ({} bytes): valid? {valid}", bytes2.len());
+    println!(
+        "my_function_raw_binary 2 big ({} bytes): valid? {valid}",
+        bytes2.len()
+    );
 }
 
 fn my_function_with_response(e: webui::Event) {
diff --git a/examples/minimal/main.rs b/examples/minimal/main.rs
@@ -4,6 +4,8 @@ use webui_rs::webui;
 
 fn main() {
     let window = webui::Window::new();
-    window.show("<html><head><script src=\"webui.js\"></script></head><body>Hello World!</body></html>");
+    window.show(
+        "<html><head><script src=\"webui.js\"></script></head><body>Hello World!</body></html>",
+    );
     webui::wait();
 }
diff --git a/examples/public_network_access/main.rs b/examples/public_network_access/main.rs
@@ -78,10 +78,16 @@ fn public_window_events(e: webui::Event) {
     let private = PRIVATE_WIN.load(Ordering::SeqCst);
     match e.event_type {
         webui::EventType::Connected => {
-            webui::run(private, "document.getElementById('Logs').value += 'New connection.\\n';");
+            webui::run(
+                private,
+                "document.getElementById('Logs').value += 'New connection.\\n';",
+            );
         }
         webui::EventType::Disconnected => {
-            webui::run(private, "document.getElementById('Logs').value += 'Disconnected.\\n';");
+            webui::run(
+                private,
+                "document.getElementById('Logs').value += 'Disconnected.\\n';",
+            );
         }
         _ => {}
     }
@@ -95,20 +101,21 @@ fn private_window_events(e: webui::Event) {
         let port = webui::get_port(public);
         let url = webui::get_url(public);
 
-        webui::run(private, format!(
-            "document.getElementById('urlSpan1').innerHTML = 'http://localhost:{port}';"
-        ));
-        webui::run(private, format!(
-            "document.getElementById('urlSpan2').innerHTML = '{url}';"
-        ));
+        webui::run(
+            private,
+            format!("document.getElementById('urlSpan1').innerHTML = 'http://localhost:{port}';"),
+        );
+        webui::run(
+            private,
+            format!("document.getElementById('urlSpan2').innerHTML = '{url}';"),
+        );
         webui::run(private, format!(
             "document.getElementById('urlSpan3').innerHTML = 'http://[ANY_IP_OF_THIS_MACHINE]:{port}';"
         ));
     }
 }
 
 fn main() {
-
     // Allow multiple connections to the same window
     webui::set_config(webui::Config::MultiClient, true);
 
diff --git a/src/webui.rs b/src/webui.rs
@@ -376,7 +376,15 @@ impl Window {
             data: "".to_string(),
         };
 
-        run_js_buffered(self.id, &mut js, if buffer_size == 0 { 1024 * 8 } else { buffer_size });
+        run_js_buffered(
+            self.id,
+            &mut js,
+            if buffer_size == 0 {
+                1024 * 8
+            } else {
+                buffer_size
+            },
+        );
 
         js
     }
@@ -447,10 +455,7 @@ impl Window {
         set_root_folder(self.id, path.as_ref())
     }
 
-    pub fn set_close_handler_wv(
-        &self,
-        handler: unsafe extern "C" fn(usize) -> bool,
-    ) {
+    pub fn set_close_handler_wv(&self, handler: unsafe extern "C" fn(usize) -> bool) {
         set_close_handler_wv(self.id, handler);
     }
 
@@ -795,7 +800,7 @@ pub fn start_server(win: usize, content: impl AsRef<str> + Into<Vec<u8>>) -> Str
         let content_c_str = CString::new(content).unwrap();
         let content_c_char: *const c_char = content_c_str.as_ptr() as *const c_char;
         let url = webui_start_server(win, content_c_char);
-        char_to_string(url as *const i8)
+        char_to_string(url)
     }
 }
 
@@ -882,7 +887,7 @@ pub fn open_url(url: impl AsRef<str> + Into<Vec<u8>>) {
 pub fn get_url(win: usize) -> String {
     unsafe {
         let url = webui_get_url(win);
-        char_to_string(url as *const i8)
+        char_to_string(url)
     }
 }
 
@@ -939,11 +944,18 @@ pub fn set_transparent(win: usize, status: bool) {
 pub fn get_mime_type(file: impl AsRef<str> + Into<Vec<u8>>) -> String {
     let file_c_str = CString::new(file).unwrap();
     let file_c_char: *const c_char = file_c_str.as_ptr() as *const c_char;
-    unsafe { char_to_string(webui_get_mime_type(file_c_char) as *const i8) }
+    unsafe { char_to_string(webui_get_mime_type(file_c_char)) }
 }
 
-pub fn memcpy(dest: *mut std::os::raw::c_void, src: *mut std::os::raw::c_void, count: usize) {
-    unsafe { webui_memcpy(dest, src, count) }
+/// # Safety
+///
+/// `dest` and `src` must be valid non-overlapping pointers to at least `count` bytes.
+pub unsafe fn memcpy(
+    dest: *mut std::os::raw::c_void,
+    src: *mut std::os::raw::c_void,
+    count: usize,
+) {
+    webui_memcpy(dest, src, count)
 }
 
 pub fn send_raw(win: usize, func: impl AsRef<str> + Into<Vec<u8>>, raw: &[u8]) {
@@ -996,7 +1008,7 @@ pub fn get_last_error_number() -> usize {
 }
 
 pub fn get_last_error_message() -> String {
-    unsafe { char_to_string(webui_get_last_error_message() as *const i8) }
+    unsafe { char_to_string(webui_get_last_error_message()) }
 }
 
 pub fn set_default_root_folder(path: impl AsRef<str> + Into<Vec<u8>>) -> bool {
@@ -1033,10 +1045,11 @@ pub fn delete_profile(win: usize) {
 
 /// Allocate a response buffer owned by WebUI so it frees the memory after serving.
 /// Use this inside a `set_file_handler` callback to return dynamic content.
-pub unsafe fn malloc(
-    response: &str,
-    length: *mut i32,
-) -> *const std::os::raw::c_void {
+///
+/// # Safety
+///
+/// `length` must be either null or a valid pointer to a writable `i32`.
+pub unsafe fn malloc(response: &str, length: *mut i32) -> *const std::os::raw::c_void {
     let buf = webui_malloc(response.len() + 1) as *mut u8;
     std::ptr::copy_nonoverlapping(response.as_ptr(), buf, response.len());
     *buf.add(response.len()) = 0;
diff --git a/src/webui/bindgen.rs b/src/webui/bindgen.rs
@@ -54,10 +54,8 @@ extern "C" {
 }
 extern "C" {
     #[doc = " @brief Show a window using embedded HTML, or a file. Single client.\n\n @param e The event struct\n @param content The HTML, URL, Or a local file\n\n @return Returns True if showing the window is successed.\n\n @example webui_show_client(e, \"<html>...</html>\");"]
-    pub fn webui_show_client(
-        e: *mut webui_event_t,
-        content: *const ::std::os::raw::c_char,
-    ) -> bool;
+    pub fn webui_show_client(e: *mut webui_event_t, content: *const ::std::os::raw::c_char)
+        -> bool;
 }
 extern "C" {
     #[doc = " @brief Same as `webui_show()`. But using a specific web browser.\n\n @param window The window number\n @param content The HTML, Or a local file\n @param browser The web browser to be used\n\n @return Returns True if showing the window is successed.\n\n @example webui_show_browser(myWindow, \"<html>...</html>\", Chrome); |\n webui_show(myWindow, \"index.html\", Firefox);"]
@@ -76,10 +74,7 @@ extern "C" {
 }
 extern "C" {
     #[doc = " @brief Show a WebView window using embedded HTML, or a file.\n\n @param window The window number\n @param content The HTML, URL, Or a local file\n\n @return Returns True if showing the WebView window is successed.\n\n @example webui_show_wv(myWindow, \"<html>...</html>\");"]
-    pub fn webui_show_wv(
-        window: usize,
-        content: *const ::std::os::raw::c_char,
-    ) -> bool;
+    pub fn webui_show_wv(window: usize, content: *const ::std::os::raw::c_char) -> bool;
 }
 extern "C" {
     #[doc = " @brief Set the window in Kiosk mode (Full screen).\n\n @param window The window number\n @param status True or False\n\n @example webui_set_kiosk(myWindow, true);"]
@@ -91,10 +86,7 @@ extern "C" {
 }
 extern "C" {
     #[doc = " @brief Add a user-defined web browser's CLI parameters.\n\n @param window The window number\n @param params Command line parameters\n\n @example webui_set_custom_parameters(myWindow, \"--remote-debugging-port=9222\");"]
-    pub fn webui_set_custom_parameters(
-        window: usize,
-        params: *mut ::std::os::raw::c_char,
-    );
+    pub fn webui_set_custom_parameters(window: usize, params: *mut ::std::os::raw::c_char);
 }
 extern "C" {
     #[doc = " @brief Set the window with high-contrast support.\n\n @param window The window number\n @param status True or False\n\n @example webui_set_high_contrast(myWindow, true);"]
@@ -385,8 +377,9 @@ extern "C" {
 }
 extern "C" {
     #[doc = " @brief Get the HTTP mime type of a file.\n\n @return Returns the HTTP mime string\n\n @example const char* mime = webui_get_mime_type(\"foo.png\");"]
-    pub fn webui_get_mime_type(file: *const ::std::os::raw::c_char)
-        -> *const ::std::os::raw::c_char;
+    pub fn webui_get_mime_type(
+        file: *const ::std::os::raw::c_char,
+    ) -> *const ::std::os::raw::c_char;
 }
 extern "C" {
     #[doc = " @brief Set the SSL/TLS certificate and the private key content, both in PEM\n format. This works only with `webui-2-secure` library. If set empty WebUI\n will generate a self-signed certificate.\n\n @param certificate_pem The SSL/TLS certificate content in PEM format\n @param private_key_pem The private key content in PEM format\n\n @return Returns True if the certificate and the key are valid.\n\n @example bool ret = webui_set_tls_certificate(\"-----BEGIN\n CERTIFICATE-----\\n...\", \"-----BEGIN PRIVATE KEY-----\\n...\");"]
@@ -556,11 +549,7 @@ extern "C" {
 }
 extern "C" {
     #[doc = " @brief Get an argument as float at a specific index.\n\n @param window The window number\n @param event_number The event number\n @param index The argument position\n\n @return Returns argument as float\n\n @example double myFloat = webui_interface_get_float_at(myWindow, e->event_number, 0);"]
-    pub fn webui_interface_get_float_at(
-        window: usize,
-        event_number: usize,
-        index: usize,
-    ) -> f64;
+    pub fn webui_interface_get_float_at(window: usize, event_number: usize, index: usize) -> f64;
 }
 extern "C" {
     #[doc = " @brief Show a window using embedded HTML, or a file. Single client.\n\n @param window The window number\n @param event_number The event number\n @param content The HTML, URL, Or a local file\n\n @return Returns True if showing the window is successed.\n\n @example webui_interface_show_client(myWindow, e->event_number, \"<html>...</html>\");"]

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ fn my_function_count(e: webui::Event) {`
`97`	`97`
`98`	`98`	`// Run JS without capturing return value (faster)`
`99`	`99`	`// No buffer needed since this is a fire and forget call.`
`100`		`- window.run(&format!("SetCount({next});"));`
	`100`	`+ window.run(format!("SetCount({next});"));`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`fn main() {`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@ use webui_rs::webui;`
`4`	`4`
`5`	`5`	`fn main() {`
`6`	`6`	`let window = webui::Window::new();`
`7`		`- window.show("<html><head><script src=\"webui.js\"></script></head><body>Hello World!</body></html>");`
	`7`	`+ window.show(`
	`8`	`+ "<html><head><script src=\"webui.js\"></script></head><body>Hello World!</body></html>",`
	`9`	`+ );`
`8`	`10`	`webui::wait();`
`9`	`11`	`}`