feat(public_network_access): improve public window link display and custom port#100
Merged
Conversation
…et custom port - set public window port to 9090 for network access - display both localhost and full URL in private window - update private.html to show two URL spans for public window - fix script src path in private.html and public.html
jinzhongjia
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves the public window link display and custom port functionality for public network access. Key changes include updating the script src paths in both HTML files, modifying the private window to display two URL spans, and setting the public window port to 9090 in the Zig server code.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/public_network_access/public.html | Updated the script src path to a relative path. |
| examples/public_network_access/private.html | Updated the script src, modified URL span IDs and display text formatting. |
| examples/public_network_access/main.zig | Added public port setting and revised JS generation for updating URL spans. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.