fix: clippy

Author: LastLeaf

float-pigment-consistent-bincode/src/config/int.rs

@@ -206,7 +206,7 @@ impl VarintEncoding {
 
     #[inline(always)]
     fn zigzag_decode(n: u64) -> i64 {
-        if n % 2 == 0 {
+        if n.is_multiple_of(2) {
             // positive number
             (n / 2) as i64
         } else {
@@ -269,7 +269,7 @@ impl VarintEncoding {
         }
         #[inline(always)]
         fn zigzag128_decode(n: u128) -> i128 {
-            if n % 2 == 0 {
+            if n.is_multiple_of(2) {
                 (n / 2) as i128
             } else {
                 !(n / 2) as i128

float-pigment-css/src/ffi.rs

@@ -352,7 +352,7 @@ pub unsafe extern "C" fn style_sheet_resource_add_bincode(
     check_null!(path, FfiErrorCode::PathNullPointer, null());
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null());
     let res = raw_ptr_as_mut_ref!(this, group::StyleSheetResource);
-    let bincode: *mut [u8] = core::slice::from_raw_parts_mut(buffer_ptr, buffer_len);
+    let bincode: *mut [u8] = core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len);
     let path = CStr::from_ptr(path).to_string_lossy();
     let w = res.add_bincode_zero_copy(&path, bincode, move || {
         if let Some(drop_fn) = drop_fn {
@@ -595,7 +595,7 @@ pub unsafe extern "C" fn style_sheet_import_index_add_bincode(
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null_mut());
     let path = CStr::from_ptr(path).to_string_lossy();
     let sheet = de_static_ref_zero_copy_env(
-        core::slice::from_raw_parts_mut(buffer_ptr, buffer_len),
+        core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len),
         |s| {
             let s: Result<StyleSheet, _> = float_pigment_consistent_bincode::DefaultOptions::new()
                 .allow_trailing_bytes()
@@ -790,7 +790,7 @@ pub unsafe extern "C" fn style_sheet_import_index_deserialize_bincode(
     drop_args: RawMutPtr,
 ) -> FfiResult<RawMutPtr> {
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null_mut());
-    let bincode: *mut [u8] = core::slice::from_raw_parts_mut(buffer_ptr, buffer_len);
+    let bincode: *mut [u8] = core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len);
     FfiResult::ok(
         StyleSheetImportIndex {
             inner: StyleSheetImportIndexImpl::deserialize_bincode_zero_copy(bincode, move || {
@@ -831,7 +831,7 @@ pub unsafe extern "C" fn style_sheet_import_index_merge_bincode(
     check_null!(this, FfiErrorCode::ThisNullPointer, null());
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null());
     let style_sheet_import_index = raw_ptr_as_mut_ref!(this, StyleSheetImportIndex);
-    let bincode: *mut [u8] = core::slice::from_raw_parts_mut(buffer_ptr, buffer_len);
+    let bincode: *mut [u8] = core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len);
     style_sheet_import_index
         .inner
         .merge_bincode_zero_copy(bincode, move || {
@@ -858,7 +858,7 @@ pub unsafe extern "C" fn style_sheet_import_index_merge_bincode(
 #[export_name = "FPBufferFree"]
 pub unsafe extern "C" fn buffer_free(buffer_ptr: *mut u8, buffer_len: usize) -> FfiResult<NullPtr> {
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null());
-    let x: *mut [u8] = core::slice::from_raw_parts_mut(buffer_ptr, buffer_len);
+    let x: *mut [u8] = core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len);
     drop(Box::from_raw(x));
     FfiResult::ok(null())
 }
@@ -1088,7 +1088,7 @@ pub unsafe extern "C" fn style_sheet_bincode_version(
     use float_pigment_consistent_bincode::Options;
     check_null!(buffer_ptr, FfiErrorCode::BufferNullPointer, null_mut());
     let sheet = de_static_ref_zero_copy_env(
-        core::slice::from_raw_parts_mut(buffer_ptr, buffer_len),
+        core::ptr::slice_from_raw_parts_mut(buffer_ptr, buffer_len),
         |s| {
             let s: Result<StyleSheet, _> = float_pigment_consistent_bincode::DefaultOptions::new()
                 .allow_trailing_bytes()
@@ -1098,10 +1098,8 @@ pub unsafe extern "C" fn style_sheet_bincode_version(
                 Err(err) => {
                     let mut ss = StyleSheet::from_sheet(&sheet::CompiledStyleSheet::new());
                     if let StyleSheet::V1(ssv) = &mut ss {
-                        ssv.version = Box::new(
-                            format!("Failed to deserialize bincode formatted style sheet: {err}")
-                                .into(),
-                        );
+                        *ssv.version = format!("Failed to deserialize bincode formatted style sheet: {err}")
+                                .into();
                     }
                     ss
                 }

float-pigment-css/src/parser/property_value/gradient.rs

@@ -822,7 +822,7 @@ fn gradient_position_repr<'a, 't: 'a, 'i: 't>(
             // hit <length-percentage>
             return Ok(GradientPosition::Pos(parsed_length, Length::Ratio(0.5)));
         }
-        return Err(parser.new_custom_error(CustomError::Unsupported));
+        Err(parser.new_custom_error(CustomError::Unsupported))
     });
 
     if parse_position_one_res.is_ok() && (!strict || parser.is_exhausted()) {

float-pigment-css/src/typing.rs

@@ -298,18 +298,14 @@ impl Length {
 #[repr(C)]
 #[derive(Clone, Debug, PartialEq, Serialize, Deserialize, ResolveFontSize)]
 #[cfg_attr(debug_assertions, derive(CompatibilityEnumCheck))]
+#[derive(Default)]
 pub enum LengthExpr {
+    #[default]
     Invalid,
     Env(StrRef, Box<Length>),
     Calc(Box<CalcExpr>),
 }
 
-impl Default for LengthExpr {
-    fn default() -> Self {
-        Self::Invalid
-    }
-}
-
 impl CalcExpr {
     fn resolve_to_f32<L: LengthNum>(
         &self,

float-pigment-layout/src/algo/grid/matrix.rs

@@ -56,9 +56,9 @@ impl OccupiedBitmap {
     fn new(stride: usize, row_order: bool, capacity: usize) -> Self {
         debug_assert!(stride >= 1);
         let stride: usize = stride.max(1);
-        let bytes_per_line = (stride + 7) / 8;
+        let bytes_per_line = stride.div_ceil(8);
         let estimated_lines = if stride > 0 {
-            (capacity + stride - 1) / stride
+            capacity.div_ceil(stride)
         } else {
             0
         };
@@ -129,7 +129,7 @@ impl OccupiedBitmap {
         debug_assert!(new_stride > self.stride, "stride can only grow");
         let new_stride: usize = new_stride.max(1);
         let old_bytes_per_line = self.bytes_per_line;
-        let new_bytes_per_line = (new_stride + 7) / 8;
+        let new_bytes_per_line = new_stride.div_ceil(8);
         let new_total_bytes = max_lines * new_bytes_per_line;
 
         self.bits.resize(new_total_bytes, 0u8);
@@ -224,7 +224,7 @@ pub(crate) struct GridMatrix<'a, T: LayoutTreeNode> {
     flow: GridAutoFlow,
 }
 
-impl<'a, 'b: 'a, T: LayoutTreeNode> GridMatrix<'a, T> {
+impl<'a, T: LayoutTreeNode> GridMatrix<'a, T> {
     /// Create a new empty grid matrix.
     ///
     /// The grid starts empty and expands dynamically when items are placed.

float-pigment-layout/src/types.rs

@@ -175,8 +175,10 @@ impl<L: LengthNum> VectorProxy<L> for Vector<L> {
 
 /// A length type that can be undefined or auto.
 #[derive(Debug, Clone, Copy, PartialEq)]
+#[derive(Default)]
 pub enum DefLength<L: LengthNum, T: PartialEq + Clone = i32> {
     /// The length is undetermined.
+    #[default]
     Undefined,
 
     /// The length is auto.
@@ -206,11 +208,6 @@ impl<L: LengthNum, T: PartialEq + Display + Clone> Display for DefLength<L, T> {
     }
 }
 
-impl<L: LengthNum, T: PartialEq + Clone> Default for DefLength<L, T> {
-    fn default() -> Self {
-        Self::Undefined
-    }
-}
 
 impl<L: LengthNum, T: PartialEq + Clone> DefLength<L, T> {
     pub(crate) fn resolve<N: LayoutTreeNode<Length = L, LengthCustom = T>>(
@@ -831,7 +828,6 @@ impl AxisInfo {
     }
 
     /// Create AxisInfo considering both writing-mode and direction.
-
     pub(crate) fn from_writing_mode_and_direction(
         writing_mode: WritingMode,
         direction: Direction,
@@ -1041,16 +1037,13 @@ pub(crate) fn size_to_option<L: LengthNum>(size: Size<L>) -> OptionSize<L> {
 
 #[allow(missing_docs)]
 #[derive(Debug, Clone, PartialEq)]
+#[derive(Default)]
 pub enum LayoutGridTemplate<L: LengthNum, T: PartialEq + Clone = i32> {
+    #[default]
     None,
     TrackList(Vec<LayoutTrackListItem<L, T>>),
 }
 
-impl<L: LengthNum, T: PartialEq + Clone> Default for LayoutGridTemplate<L, T> {
-    fn default() -> Self {
-        Self::None
-    }
-}
 
 #[allow(missing_docs)]
 #[derive(Debug, Clone, PartialEq)]