Skip to content

Commit 8df582e

Browse files
committed
test(margin): fix top expectation in margin_not_collapse_if_padding_exists_2
The outer wrapper has border:1px, so the child layout top = parent border (1) + margin-top (20) = 21, not 20. Corrected data-expect-top 20->21 and removed the temporary data-ignore. Other assertions (n3/n4 top via padding/margin, n2 height 90) were already correct.
1 parent 96f6918 commit 8df582e

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

float-pigment-forest/tests/cases/custom_css_margin/margin_not_collapse_if_padding_exists_2.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<!DOCTYPE html>
2-
<!-- FIXME: layout-top expectations predate the style-attribute fixup; float-pigment
3-
layout top includes the parent border (21 not 20, etc.). Needs re-derivation. Ignored meanwhile. -->
4-
<div style="border: 1px;" data-chrome="false" data-ignore="true">
5-
<div style="padding-top: 30px; border-bottom: 10px; margin-top: 20px; margin-bottom: 20px;" data-expect-top="20" data-expect-height="90">
2+
<div style="border: 1px;" data-chrome="false">
3+
<div style="padding-top: 30px; border-bottom: 10px; margin-top: 20px; margin-bottom: 20px;" data-expect-top="21" data-expect-height="90">
64
<div style="margin-top: 10px; margin-bottom: 10px; width: 10px; height: 10px;" data-expect-top="40"></div>
75
<div style="margin-top: 5px; margin-bottom: 10px; width: 10px; height: 10px;" data-expect-top="60"></div>
86
</div>

0 commit comments

Comments
 (0)