New script colorize_regex.pl: colorize highlight regex matches in chat messages#573
New script colorize_regex.pl: colorize highlight regex matches in chat messages#573ryoskzypu wants to merge 1 commit into
Conversation
8e3c91a to
3543415
Compare
|
how about improving colorize_lines.pl? |
Sure, do you mean I should've added the regex colorizing in colorize_lines.pl? |
|
maybe its better to add the regex function to colorize_lines.pl, to have one script with nearly same functionality. what do you think @flashcode ? |
|
It depends if it's simple to add into colorize_lines.pl, and it could prevent duplicated code. |
The scripts are different in many ways, e.g. colorize_regex has a command like /debug unicode, a dedicated buffer that shows commands/debug output, uses hook_line rather than hook_modifier, uses config_new(), etc. I could add all the features to colorize_lines.pl, but I don't know if it's okay; or only the highlight_regex function. |
|
@ryoskzypu: then let's keep the separate script. |
0aaee24 to
3543415
Compare
f07f9bc to
5c0472c
Compare
d5c85f0 to
6c56d46
Compare
6c56d46 to
c9329ae
Compare
|
@flashcode: Done, I think it is ok now? Sorry for the force-push noise, I've messed up when rebasing my fork... |
|
Thanks, script merged (I moved script to perl/ directory). |
Script info
Description
Colorize regex matches in chat messages from 'weechat.look.highlight_regex' option or the 'highlight_regex' buffer property, to make validation of matches easier.
Checklist (new script)
New script name.py: short description…hook_url,hook_processorhook_process_hashtableis used for any blocking call