Skip to content

test: Add test for DebugView orphan instances#253

Merged
alt-romes merged 1 commit into
masterfrom
wip/romes/fixes-4
Apr 23, 2026
Merged

test: Add test for DebugView orphan instances#253
alt-romes merged 1 commit into
masterfrom
wip/romes/fixes-4

Conversation

@alt-romes
Copy link
Copy Markdown
Collaborator

Seemingly, #237 is not about all orphan instances, but rather some
slightly more contrived scenario that prevents us from using a
DebugView ModuleGraph defined as an orphan in the debugger when
debugging the debugger.

This test checks that orphan instances in a normal situation work
properly.

Complements the tests added in the fix to #237

Comment thread test/golden/T237/T237.ghc-914.hdb-stdout
@alt-romes
Copy link
Copy Markdown
Collaborator Author

@Saizan can I hand this test over to you? Perhaps you can incorporate it as part of the patch for #237.

here, it seems to return the wrong result!

@alt-romes
Copy link
Copy Markdown
Collaborator Author

Nevermind @Saizan, the only issue here is that #251 hadn't landed yet. Now that it has, this will work without further work.

@alt-romes alt-romes force-pushed the wip/romes/fixes-4 branch 2 times, most recently from ad76b41 to cde69be Compare March 30, 2026 14:34
@alt-romes alt-romes changed the title Add test for DebugView orphan instances test: Add test for DebugView orphan instances Mar 30, 2026
Seemingly, #237 is not about all orphan instances, but rather some
slightly more contrived scenario that prevents us from using a
`DebugView ModuleGraph` defined as an orphan in the debugger when
debugging the debugger.

This test checks that orphan instances in a normal situation work
properly.
@alt-romes alt-romes merged commit 32cfa5c into master Apr 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant