Conversation
|
I think this could probably be cherry-picked onto master without conflicts if it makes more sense |
alt-romes
left a comment
alt-romes
left a comment
There was a problem hiding this comment.
Great finding!! I think the wording could just be improved because I couldn't follow it very clearly
| resumeExec :: GhcMonad m => SingleStep -> Maybe Int -> m ExecResult | ||
| resumeExec a b = do | ||
| v <- GHC.resumeExec a b | ||
| -- resumeExec resets the scope of the IC to what it was before the last |
There was a problem hiding this comment.
It's unclear if you're referring to GHC's behavior or our new overwritten behavior
There was a problem hiding this comment.
In general, this comment is a bit confusing because this distinction isn't clear
|
Could you make this MR against master? I agree |
alt-romes
left a comment
alt-romes
left a comment
There was a problem hiding this comment.
Much better! Could you rebase on master and discard all commits except the top-most? I can help you if it's not clear how to do that.
Basically, make the MR just to merge that last commit to master
2 participants
Turns out the culprit for #242 was resumeExec resetting the scope to the one before the last break, with no care for consistency with the
ic_importsfield.That also means we can just setContext again with the saved imports to get our scope right.