Fix testcase T130b by Exposing packages from module graph by Saizan · Pull Request #281 · well-typed/haskell-debugger

Saizan · 2026-04-23T07:28:29Z

No description provided.

alt-romes · 2026-04-23T08:28:28Z

This makes sense to me, but given how much time we've spent chasing this bug it would be good to offer a more comprehensive commentary and some -- !! WARNING !! comment or something about how important it is.
(that is, I think a Note is warranted in the location where you call "setExposeUnit ... final_mod_graph.

Note [Why the final mod graph units must be exposed explicitly] or something like that.

The commit message should reference the note and #224

alt-romes · 2026-04-23T08:28:40Z

Does this also fix #238 ?

Saizan · 2026-04-23T09:51:57Z

@alt-romes seems to fix #238 when not using a multi-repl (so the breakpoint needs to be in the hdb exe)

alt-romes · 2026-04-23T09:53:38Z

@alt-romes seems to fix #238 when not using a multi-repl (so the breakpoint needs to be in the hdb exe)

Interesting! Sounds good, let's do that and open a new ticket for what doesn't work exactly with multi-reps

Saizan · 2026-04-23T11:36:26Z

@alt-romes pushed the note

Also changed it so the units we expose are the same ones used to find haskell-debugger-view

With that I only get problems for #238 when I run the (debugger) server from an empty directory. This compilation error shows up in the log:

{
    "body": {
        "output": "[22 of 52] Compiling GHC.Debugger.Session.Builtin ( /home/andrea/haskell-debugger/haskell-debugger/GHC/Debugger/Session/Builtin.hs, interpreted )[haskell-debugger-0.12.3.0-inplace]\n"
    },
    "event": "output",
    "type": "event"
}
<no location info>: error:
    haskell-debugger-view/src/GHC/Debugger/View/ByteString.hs: withBinaryFile: does not exist (No such file or directory)

which I guess it's fair enough, because the embedStringFile calls just use a relative path

alt-romes

Excellent @Saizan! Can you squash the two commits and add two lines to the commit description saying

Fix #224
Fix #238

alt-romes · 2026-04-23T12:23:11Z

+        -- The `moduleNameProvidersMap` has so far only been required to expose,
+        -- with `ExposePackage` flags, the other home units. However since
+        -- exposing a package **does not** imply exposing its dependencies,
+        -- `mkUnitState` was free to make a choice for us to, e.g., expose
+        -- haskell-debugger-view-0.2.1.0-... and hide
+        -- haskell-debugger-view-0.2.0.0-..., while the latter is the one in the
+        -- graph. While we noticed with `hdv` this can happen with any dep of
+        -- the debuggee, causing problems at the prompt.


If you explicitly expose haskell-debugger-view-0.2.0.0, can haskell-debugger-view-0.2.1.0 somehow be implicitly exposed too?

Or does the latter only get picked because there was no explicit exposed one?

AFAIU within a unit exposing one hides the other, that's how we were getting the "hidden haskell-debugger-view-0.2.0.0" errors

With this patch we are getting a moduleNameProvidersMap like this

GHC.Debugger.View.ByteString -> [haskell-debugger-view-0.2.1.0-07408397037260571bbb43df8171563563272313fc0e1d44ecbe94247d64898c:GHC.Debugger.View.ByteString -> hidden package, haskell-debugger-view-0.1.0.0-cb5cc57a3201894d30a97d95a1f27b60067ae17b4d6adbcb1d5efb3bcd8dee70:GHC.Debugger.View.ByteString -> hidden package, haskell-debugger-view-0.2.1.0-485ee981ab310332f3c47b6c6152d45b363aaa196c64e88e618138a303829605:GHC.Debugger.View.ByteString -> hidden package, haskell-debugger-view-0.1.0.0-0ebb86c4670f51466882b864d00204afbac54b16469b47f05764ca5eb4ca769a:GHC.Debugger.View.ByteString -> hidden package, haskell-debugger-view-0.2.0.0-52ddb3bad2a4102ae4edfefad3d6fe5050b8f4175993b0a200186c71f37b526a:GHC.Debugger.View.ByteString -> exposed package, haskell-debugger-view-0.2.0.0-279c347bd3a91676a96135a63cdb9fc7f289a6ccc10db93f3b1e9b53930ca231:GHC.Debugger.View.ByteString -> hidden package], GHC.Debugger.View.Class -> [haskell-debugger-view-0.2.1.0-07408397037260571bbb43df8171563563272313fc0e1d44ecbe94247d64898c:GHC.Debugger.View.Class -> hidden package, haskell-debugger-view-0.1.0.0-cb5cc57a3201894d30a97d95a1f27b60067ae17b4d6adbcb1d5efb3bcd8dee70:GHC.Debugger.View.Class -> hidden package, haskell-debugger-view-0.2.1.0-485ee981ab310332f3c47b6c6152d45b363aaa196c64e88e618138a303829605:GHC.Debugger.View.Class -> hidden package, haskell-debugger-view-0.1.0.0-0ebb86c4670f51466882b864d00204afbac54b16469b47f05764ca5eb4ca769a:GHC.Debugger.View.Class -> hidden package, haskell-debugger-view-0.2.0.0-52ddb3bad2a4102ae4edfefad3d6fe5050b8f4175993b0a200186c71f37b526a:GHC.Debugger.View.Class -> exposed package, haskell-debugger-view-0.2.0.0-279c347bd3a91676a96135a63cdb9fc7f289a6ccc10db93f3b1e9b53930ca231:GHC.Debugger.View.Class -> hidden package], GHC.Debugger.View.Containers -> [haskell-debugger-view-0.2.1.0-07408397037260571bbb43df8171563563272313fc0e1d44ecbe94247d64898c:GHC.Debugger.View.Containers -> hidden package, haskell-debugger-view-0.1.0.0-cb5cc57a3201894d30a97d95a1f27b60067ae17b4d6adbcb1d5efb3bcd8dee70:GHC.Debugger.View.Containers -> hidden package, haskell-debugger-view-0.2.1.0-485ee981ab310332f3c47b6c6152d45b363aaa196c64e88e618138a303829605:GHC.Debugger.View.Containers -> hidden package, haskell-debugger-view-0.1.0.0-0ebb86c4670f51466882b864d00204afbac54b16469b47f05764ca5eb4ca769a:GHC.Debugger.View.Containers -> hidden package, haskell-debugger-view-0.2.0.0-52ddb3bad2a4102ae4edfefad3d6fe5050b8f4175993b0a200186c71f37b526a:GHC.Debugger.View.Containers -> exposed package, haskell-debugger-view-0.2.0.0-279c347bd3a91676a96135a63cdb9fc7f289a6ccc10db93f3b1e9b53930ca231:GHC.Debugger.View.Containers -> hidden package], GHC.Debugger.View.Text -> [haskell-debugger-view-0.2.1.0-07408397037260571bbb43df8171563563272313fc0e1d44ecbe94247d64898c:GHC.Debugger.View.Text -> hidden package, haskell-debugger-view-0.1.0.0-cb5cc57a3201894d30a97d95a1f27b60067ae17b4d6adbcb1d5efb3bcd8dee70:GHC.Debugger.View.Text -> hidden package, haskell-debugger-view-0.2.1.0-485ee981ab310332f3c47b6c6152d45b363aaa196c64e88e618138a303829605:GHC.Debugger.View.Text -> hidden package, haskell-debugger-view-0.1.0.0-0ebb86c4670f51466882b864d00204afbac54b16469b47f05764ca5eb4ca769a:GHC.Debugger.View.Text -> hidden package, haskell-debugger-view-0.2.0.0-52ddb3bad2a4102ae4edfefad3d6fe5050b8f4175993b0a200186c71f37b526a:GHC.Debugger.View.Text -> exposed package, haskell-debugger-view-0.2.0.0-279c347bd3a91676a96135a63cdb9fc7f289a6ccc10db93f3b1e9b53930ca231:GHC.Debugger.View.Text -> hidden package],

Ah! Makes sense.

Land when ready.

With this patch we are getting a moduleNameProvidersMap like this

This is perfect, just the correct versions are exposed 👍

alt-romes · 2026-04-23T12:26:08Z

which I guess it's fair enough, because the embedStringFile calls just use a relative path

That's right, I wouldn't expect that to work because of embedStringFile.

Excellent that #238 is fixed by this too!

See Note [Must explicitly expose module graph units]. Fix #224 Fix #238

Saizan requested review from alt-romes and fendor and removed request for alt-romes April 23, 2026 07:43

Saizan force-pushed the fixT130b branch from 44a55ac to 9234571 Compare April 23, 2026 11:22

alt-romes reviewed Apr 23, 2026

View reviewed changes

Must explicitly expose module graph units

b78ab0f

See Note [Must explicitly expose module graph units]. Fix #224 Fix #238

Saizan force-pushed the fixT130b branch from 9234571 to b78ab0f Compare April 23, 2026 12:40

alt-romes approved these changes Apr 23, 2026

View reviewed changes

This was linked to issues Apr 23, 2026

Test T130b fails locally and is blocking CI #224

Closed

Import fails because of hidden package when package is depended upon #238

Closed

Do not crash on haskell-debugger-view-inplace

3ab9fee

alt-romes merged commit de608cf into master Apr 23, 2026
5 checks passed

alt-romes mentioned this pull request Apr 24, 2026

Fix #234 T130b #235

Closed

Conversation

Saizan commented Apr 23, 2026

Uh oh!

alt-romes commented Apr 23, 2026

Uh oh!

alt-romes commented Apr 23, 2026

Uh oh!

Saizan commented Apr 23, 2026

Uh oh!

alt-romes commented Apr 23, 2026

Uh oh!

Saizan commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alt-romes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alt-romes Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

alt-romes Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Saizan Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Saizan Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alt-romes Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

alt-romes Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

alt-romes commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Saizan commented Apr 23, 2026 •

edited

Loading

Saizan Apr 23, 2026 •

edited

Loading

alt-romes commented Apr 23, 2026 •

edited

Loading