Fix hd-view package-qualified imports bypassing home-unit#284
Merged
Conversation
See Note [Do not package-qualify imports for home units] Fixes #283
alt-romes
force-pushed
the
wip/romes/283
branch
from
b7e90e0 to
1df5537
Compare
Saizan
reviewed
Apr 23, 2026
| loaded, is not installed | ||
|
|
||
| 2) a package-import of a loaded unit succeeds, because a unit with the same | ||
| name (but not necessarily the same unit-id!), is installed. |
Collaborator
There was a problem hiding this comment.
Maybe clarify that you mean import "haskell-debugger-view" ... can be ambiguous, at it's not a full unitId. But we use the full unitIdString in the RawPkgQual which sould be unambiguous?
Collaborator
Author
There was a problem hiding this comment.
That's us, but a user can use a package-qualified import without it being the specific unit-id.
Sorry, I missed this comment before merging.
Saizan
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Note [Do not package-qualify imports for home units]
Fixes #283