test: Debug and validate the debugger itself#286
Merged
Conversation
Collaborator
Author
|
hie-bios is not happy: |
Collaborator
Author
|
We probably also need to normalize the ROOT DIRECTORY out |
alt-romes
force-pushed
the
wip/romes/245
branch
4 times, most recently
from
eb753b3 to
29d0b56
Compare
Collaborator
Author
|
I was able to reproduce this locally with: |
alt-romes
force-pushed
the
wip/romes/245
branch
from
29d0b56 to
9a9cb2e
Compare
alt-romes
added a commit
that referenced
this pull request
Apr 24, 2026
Introduce a test which tests loading the haskell-debugger onto itself, setting a breakpoint on `runDebugger`, and printing a `FastString` value, expecting the value to be printed according to the pretty `instance DebugView FastString` we gave in `GHC.Debugger.Utils.Orphans`. From here on, we should aim to introduce more `DebugView` instances for the `haskell-debugger` types and (orphan) instances for the `ghc` types, aiming to make debugging the debugger as seamless as possible (also to dogfood this all!) The debugger.yaml CI has to be tweaked to /not/ persist --enable-tests with cabal configure, because when the debugger loads itself it looks at the configured plan and loading the tests which have a build-tool-depends on a multi-repl with that same tool currently fails (see #286) Fixes #245
alt-romes
force-pushed
the
wip/romes/245
branch
from
9a9cb2e to
e63b1e4
Compare
Introduce a test which tests loading the haskell-debugger onto itself, setting a breakpoint on `runDebugger`, and printing a `FastString` value, expecting the value to be printed according to the pretty `instance DebugView FastString` we gave in `GHC.Debugger.Utils.Orphans`. From here on, we should aim to introduce more `DebugView` instances for the `haskell-debugger` types and (orphan) instances for the `ghc` types, aiming to make debugging the debugger as seamless as possible (also to dogfood this all!) The debugger.yaml CI has to be tweaked to /not/ persist --enable-tests with cabal configure, because when the debugger loads itself it looks at the configured plan and loading the tests which have a build-tool-depends on a multi-repl with that same tool currently fails (see #286) Fixes #245
alt-romes
force-pushed
the
wip/romes/245
branch
from
e63b1e4 to
8bcca3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a test which tests loading the haskell-debugger onto itself, setting a breakpoint on
runDebugger, and printing aFastStringvalue, expecting the value to be printed according to the prettyinstance DebugView FastStringwe gave inGHC.Debugger.Utils.Orphans.From here on, we should aim to introduce more
DebugViewinstances for thehaskell-debuggertypes and (orphan) instances for theghctypes, aiming to make debugging the debugger as seamless as possible (also to dogfood this all!)Fixes #245