test: Add test for #301#302
Open
alt-romes wants to merge 1 commit into
Open
Conversation
alt-romes
force-pushed
the
wip/romes/debug-view-bug
branch
from
487dd18 to
edd6a24
Compare
If we use an arbitrary computation as the value for a DebugView field, which is re-created from scratch everytime we recompute that DebugView fields, then evaluating that thunk is not persisted across refreshing the variable. Every time we re-fresh the variable we re-create the thunk, so it makes some sense that forcing it is not persisted across re-freshing, but still a bit unsatisfactory (esp. since the variables are invalidated as soon as a variable is forced, so we only see a flash of these values) Marked as expect fail. Tracked by #301
alt-romes
force-pushed
the
wip/romes/debug-view-bug
branch
from
edd6a24 to
f5b5598
Compare
Collaborator
Author
|
Maybe this shouldn't be considered unexpected behavior. Would the user ever want these fields to be lazy? I guess if we don't want to do the work straight away but still have the option to display on force would be useful. However, that means we'd need a way of persisting the value across invocations. Potentially by extending See #301 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use an arbitrary computation as the value for a DebugView field,
which is re-created from scratch everytime we recompute that DebugView
fields, then evaluating that thunk is not persisted across refreshing
the variable.
Every time we re-fresh the variable we re-create the thunk, so it makes
some sense that forcing it is not persisted across re-freshing, but
still a bit unsatisfactory (esp. since the variables are invalidated as
soon as a variable is forced, so we only see a flash of these values)
See #301