Conversation
Saizan
changed the title
Saizan
force-pushed
the
issue266
branch
3 times, most recently
from
91ea119 to
c6d893b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second part of #266: the different ways of running a debuggee are now handled uniformly through an API that they all implement.
Everything to do with the
runInTerminalfeature is DAP specific, so we ended up with two abstractions rather than one:InterpreterSettingstells you what top-level DynFlags to set, and how to setup the GHC interpreter.DAPDebuggee: containsInterpreterSettingsbut also extra debug session threads, post-action (to send runInTerminal request), and a method to wait for the debuggee to be ready.hdb clionly uses theInterpreterSettingsabstraction, while thehdb serverusesDAPDebugee(c.f. initDebugger).We now throw an exception when we realize -f[no-]external-interpreter has been set in a way inconsistent with hdb's own flags.
Some code was found to be dead and removed.
Sockets opened to find an open port are kept open and used for the server, so we avoid a race condition on which session gets to use the port (though probably hard to trigger).