fix: WPS529 false positive

Author: vldmrdev

CHANGELOG.md

@@ -21,6 +21,7 @@ Semantic versioning in our case means:
 ### Bugfixes
 
 - Fixes the false positive `WPS222` for nested conditions, #3630
+- Fixes the false positive `WPS529` for dict subscripts in the `else` branch, #3501
 
 
 ## 1.6.1

tests/test_visitors/test_ast/test_subscripts/test_implicit_get.py

@@ -44,6 +44,13 @@
     ...
 """
 
+else_subscripts = """
+if 'a' in kwargs:
+    pass
+else:
+    kwargs['a'] = other(kwargs)
+"""
+
 
 @pytest.mark.parametrize(
     'template',
@@ -122,3 +129,24 @@ def test_correct_if(
     visitor.run()
 
     assert_errors(visitor, [])
+
+
+@pytest.mark.parametrize(
+    'code',
+    [
+        else_subscripts,
+    ],
+)
+def test_no_implicit_dict_get_in_else_branch(
+    assert_errors,
+    parse_ast_tree,
+    default_options,
+    code,
+):
+    """Testing that subscripts in `else` branch do not trigger violation."""
+    tree = parse_ast_tree(code)
+
+    visitor = ImplicitDictGetVisitor(default_options, tree=tree)
+    visitor.run()
+
+    assert_errors(visitor, [])

wemake_python_styleguide/violations/refactoring.py

@@ -1135,7 +1135,9 @@ class ImplicitDictGetViolation(ASTViolation):
             print(collection[key])
 
     .. versionadded:: 0.13.0
-
+    .. versionadded:: 1.7.0
+        Excluded the `else` branch, check scope changed from
+        the whole ast.If to node.body.
     """
 
     error_template = 'Found implicit `.get()` dict usage'

wemake_python_styleguide/visitors/ast/subscripts.py

@@ -1,4 +1,5 @@
 import ast
+from collections.abc import Iterator
 from typing import ClassVar, final
 
 from wemake_python_styleguide.logic import source
@@ -127,6 +128,11 @@ def visit_If(self, node: ast.If) -> None:
         self._check_implicit_get(node)
         self.generic_visit(node)
 
+    def _walk_body(self, body: list[ast.stmt]) -> Iterator[ast.AST]:
+        """Yields all nodes strictly within a list of statements."""
+        for stmt in body:
+            yield from ast.walk(stmt)
+
     def _check_implicit_get(self, node: ast.If) -> None:
         if not isinstance(node.test, ast.Compare):
             return
@@ -136,7 +142,7 @@ def _check_implicit_get(self, node: ast.If) -> None:
         checked_key = source.node_to_string(node.test.left)
         checked_collection = source.node_to_string(node.test.comparators[0])
 
-        for sub in ast.walk(node):
+        for sub in self._walk_body(node.body):
             if not isinstance(sub, ast.Subscript):
                 continue