Fix ##3397

Author: LordGvozd

tests/test_visitors/test_ast/test_builtins/test_numbers/test_magic_numbers.py

@@ -29,6 +29,8 @@ def function_name(param1, param2: int = {0}):
 set_definition = '{{"first", {0}, "other"}}'
 tuple_definition = '({0}, )'
 
+literal_type_hint = 'code: Literal[{0}] = {0}'
+
 # Wrong usages:
 
 assignment_binop = 'final = {0} + 1'
@@ -68,6 +70,10 @@ def method(self):
 some_dict[{0}]
 """
 
+not_literal_type_hint = """
+foo: Bar[{0}] = {0}
+"""
+
 
 @pytest.mark.parametrize(
     'code',
@@ -83,6 +89,7 @@ def method(self):
         dict_definition_value,
         set_definition,
         tuple_definition,
+        literal_type_hint,
     ],
 )
 @pytest.mark.parametrize(
@@ -145,6 +152,7 @@ def test_magic_number(
         inside_method,
         list_index,
         dict_key,
+        not_literal_type_hint
     ],
 )
 @pytest.mark.parametrize(
@@ -194,6 +202,7 @@ def test_magic_number_whitelist(
         inside_method,
         list_index,
         dict_key,
+        not_literal_type_hint
     ],
 )
 @pytest.mark.parametrize(
@@ -244,6 +253,7 @@ def test_magic_number_warning(
         inside_method,
         list_index,
         dict_key,
+        not_literal_type_hint
     ],
 )
 @pytest.mark.parametrize(

wemake_python_styleguide/visitors/ast/builtins.py

@@ -189,15 +189,15 @@ def visit_Num(self, node: ast.Constant) -> None:
 
     def _check_is_magic(self, node: ast.Constant) -> None:
         parent = operators.get_parent_ignoring_unary(node)
-        if isinstance(parent, self._allowed_parents):
-            return
-
-        if node.value in constants.MAGIC_NUMBERS_WHITELIST:
-            return
 
-        if isinstance(node.value, int) and node.value <= self._non_magic_modulo:
+        if any((
+            isinstance(parent, self._allowed_parents),
+            node.value in constants.MAGIC_NUMBERS_WHITELIST,
+            isinstance(node.value, int)
+            and node.value <= self._non_magic_modulo,
+            self._check_is_number_in_typing_literal(parent),
+        )):
             return
-
         try:
             token = self._token_dict[node.lineno, node.col_offset]
         except KeyError:  # pragma: no cover
@@ -212,6 +212,13 @@ def _check_is_magic(self, node: ast.Constant) -> None:
             best_practices.MagicNumberViolation(node, text=real_value),
         )
 
+    def _check_is_number_in_typing_literal(self, node: ast.AST | None) -> bool:
+        return (
+            isinstance(node, ast.Subscript)
+            and isinstance(node.value, ast.Name)
+            and node.value.id == 'Literal'
+        )
+
     def _check_is_approximate_constant(self, node: ast.Constant) -> None:
         try:
             precision = len(str(node.value).split('.')[1])