Fixes #3417 , #3420 (#3423)

* Allow to use ast.Subscript in the decorator (#3417)

* Remove unnecessary rules from noqa.py (#3420)

Author: MIXgleb

CHANGELOG.md

@@ -27,8 +27,17 @@ Semantic versioning in our case means:
 
 ### Bugfixes
 
+- Removes unnecessary WPS604 and WPS614 rules from the noqa.py, #3420
 - Fixes `WPS115` false-positive on `StrEnum`, `IntEnum`, `IntFlag` attributes, #3381
 - Fixes `WPS432`, now it ignores magic numbers in `Literal`, #3397
+- Fixes `WPS466` for generic type specifications `MyClassDecorator[T]`, #3417
+
+Due to PEP-695, it's now allowed to use `[]` in the decorator only for `python3.12+`.
+
+```python
+@MyClassDecorator[T, V]
+def some_function(): ...
+```
 
 ## 1.1.0
 

tests/fixtures/noqa/noqa.py

@@ -107,7 +107,7 @@ def __init__(self):
         self.boom = 7
 
 
-@property  # noqa: WPS614
+@property
 def function_name(  # noqa: WPS614
     value: int = 0,  # noqa: WPS110
 ):
@@ -118,7 +118,7 @@ def function_name(  # noqa: WPS614
 
 def some():  # noqa: WPS110
     class Nested:  # noqa: WPS431
-        """Docs."""  # noqa: WPS604
+        """Docs."""
 
     def nested():  # noqa: WPS430
         ...
@@ -730,7 +730,7 @@ def wrong_comprehension2():
     my_print(4)
 
 
-@some_decorator['text']  # noqa: WPS466
+@some_decorator + other_decorator  # noqa: WPS466
 def my_function():
     return 1
 

tests/test_visitors/test_ast/test_decorators/test_new_style_decorators.py

@@ -1,5 +1,6 @@
 import pytest
 
+from wemake_python_styleguide.compat.constants import PY312
 from wemake_python_styleguide.violations.best_practices import (
     NewStyledDecoratorViolation,
 )
@@ -18,6 +19,39 @@ class Some:
     def some(self): ...
 """
 
+invalid_decorators = [
+    'some[1]',
+    'some.attr[0]',
+    'some[0].attr',
+    'call()[1].attr',
+    'some + other',
+    'really @ strange[0]',
+]
+
+valid_decorators = [
+    'some',
+    'some()',
+    'some(index[1])',
+    'some.attr',
+    'some.attr(1 + 1)',
+]
+
+invalid_decorators3_12 = [
+    'some + other',
+    'some[1] + other[1]',
+    'some.attr + other.attr',
+    'some[0].attr + other.attr[0]',
+    'really @ strange[0]',
+]
+
+valid_decorators3_12 = [
+    *valid_decorators,
+    'some[my_type]',
+    'some[my_type](index)',
+    'some.attr[my_type]()',
+    'some.attr(1)[my_type]',
+]
+
 
 @pytest.mark.parametrize(
     'code',
@@ -28,14 +62,7 @@ def some(self): ...
 )
 @pytest.mark.parametrize(
     'decorator',
-    [
-        'some[1]',
-        'some.attr[0]',
-        'some[0].attr',
-        'call()[1].attr',
-        'some + other',
-        'really @ strange[0]',
-    ],
+    invalid_decorators3_12 if PY312 else invalid_decorators,
 )
 def test_invalid_decorators(
     assert_errors,
@@ -63,13 +90,7 @@ def test_invalid_decorators(
 )
 @pytest.mark.parametrize(
     'decorator',
-    [
-        'some',
-        'some()',
-        'some(index[1])',
-        'some.attr',
-        'some.attr(1 + 1)',
-    ],
+    valid_decorators3_12 if PY312 else valid_decorators,
 )
 def test_valid_decorators(
     assert_errors,

wemake_python_styleguide/violations/best_practices.py

@@ -2662,7 +2662,8 @@ class NewStyledDecoratorViolation(ASTViolation):
        Because decorators should be simple and easy to read.
 
     Solution:
-        Use names, attributes, and calls as decorators only.
+        Use names, attributes and calls with generic type specifications
+        as decorators only.
         You are free to pass any args to function calls, however.
 
     Example::
@@ -2671,8 +2672,18 @@ class NewStyledDecoratorViolation(ASTViolation):
         @some.decorator(args)
         def my_function(): ...
 
+        Only for ``python3.12+``
+        @MyClassDecorator[my_type](args)
+        def my_function(): ...
+
         # Wrong:
-        @some.decorator['method'] + other
+        @some.decorator + other.decorator
+        def my_function(): ...
+
+        @some.dict_decorators['method']
+        def my_function(): ...
+
+        @some.list_decorators[index]
         def my_function(): ...
 
     .. versionadded:: 0.15.0

wemake_python_styleguide/visitors/ast/decorators.py

@@ -1,7 +1,9 @@
 import ast
 from typing import Final, final
 
+from wemake_python_styleguide.compat.constants import PY312
 from wemake_python_styleguide.logic.tree import attributes
+from wemake_python_styleguide.options.validation import ValidatedOptions
 from wemake_python_styleguide.types import AnyFunctionDef
 from wemake_python_styleguide.violations.best_practices import (
     NewStyledDecoratorViolation,
@@ -15,6 +17,11 @@
     ast.Name,
 )
 
+_ALLOWED_DECORATOR_TYPES3_12: Final = (
+    *_ALLOWED_DECORATOR_TYPES,
+    ast.Subscript,  # PEP 695 - Type Parameter Syntax
+)
+
 
 @final
 @alias(
@@ -27,6 +34,18 @@
 class WrongDecoratorVisitor(BaseNodeVisitor):
     """Checks decorators's correctness."""
 
+    def __init__(
+        self,
+        options: ValidatedOptions,
+        tree: ast.AST,
+        **kwargs,
+    ) -> None:
+        """Creates Decorator Visitor."""
+        self.ALLOWED_DECORATOR_TYPES: Final = (
+            _ALLOWED_DECORATOR_TYPES3_12 if PY312 else _ALLOWED_DECORATOR_TYPES
+        )
+        super().__init__(options, tree, **kwargs)
+
     def visit_any_function(self, node: AnyFunctionDef) -> None:
         """Checks functions' decorators."""
         self._check_new_decorator_syntax(node)
@@ -38,13 +57,13 @@ def _check_new_decorator_syntax(self, node: AnyFunctionDef) -> None:
                 self.add_violation(NewStyledDecoratorViolation(decorator))
 
     def _is_allowed_decorator(self, node: ast.expr) -> bool:
-        if not isinstance(node, _ALLOWED_DECORATOR_TYPES):
+        if not isinstance(node, self.ALLOWED_DECORATOR_TYPES):
             return False
 
         if isinstance(node, ast.Name):
             return True  # Simple names are fine!
 
         return all(
-            isinstance(part, _ALLOWED_DECORATOR_TYPES)
+            isinstance(part, self.ALLOWED_DECORATOR_TYPES)
             for part in attributes.parts(node)
         )