Skip to content

Fix wps430 false positive#3590

Closed
albertedwardson wants to merge 2 commits into
wemake-services:masterfrom
albertedwardson:fix-WPS430-false-positive
Closed

Fix wps430 false positive#3590
albertedwardson wants to merge 2 commits into
wemake-services:masterfrom
albertedwardson:fix-WPS430-false-positive

Conversation

@albertedwardson

@albertedwardson albertedwardson commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #3589

Actually, there was already a test case for this, but it was wrong and assumed that deep nested whitelisted functions must be reported.

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test case :)

@codecov

codecov Bot commented Jan 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5198e40) to head (69c8aae).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3590   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          369       369           
  Lines        12290     12290           
  Branches       848       848           
=========================================
  Hits         12290     12290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertedwardson albertedwardson deleted the fix-WPS430-false-positive branch January 31, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for WPS430 with whitelisted name

2 participants