You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
setup.py bug (line 18):
python
version = sys.argv[-1].split("=")[1] # IndexError if no version arg
This breaks pip install git+https://github.com/...
Missing Japanese data in package_data:
'itn': ['.fst', 'chinese/data//.tsv'], # Missing: 'japanese/data//*.tsv'
Request
Could you please:
Fix setup.py to handle version gracefully (e.g., default to "0.0.0" or read from a VERSION file)
Add Japanese data files to package_data
Publish a new release to PyPI
Impact
Users wanting Japanese ITN must manually clone repo, run python setup.py install version=X.X.X, and copy data files - this breaks CI/CD pipelines.
Current Status
Issues Preventing pip install from GitHub
setup.py bug (line 18):
python
version = sys.argv[-1].split("=")[1] # IndexError if no version arg
This breaks pip install git+https://github.com/...
Missing Japanese data in package_data:
'itn': ['.fst', 'chinese/data//.tsv'], # Missing: 'japanese/data//*.tsv'
Request
Could you please:
Impact
Users wanting Japanese ITN must manually clone repo, run python setup.py install version=X.X.X, and copy data files - this breaks CI/CD pipelines.
Thank you for the great project! 🙏