fix: use module-level logger to allow user control over log level - #334
Merged
Conversation
Previously, build_fst() created a new logger with hardcoded INFO level
and a new handler on every call, making it impossible for users to
suppress logs. Now uses a single module-level "wetext" logger initialized
once, so users can control it via:
import logging
logging.getLogger("wetext").setLevel(logging.WARNING)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #311
Summary
build_fst()with a single module-level"wetext"loggerBefore: Every
build_fst()call created a new logger, set INFO level, and added a handler — users could not suppress logs, and handlers accumulated causing duplicate output.After: Single logger, configured once, user-controllable.
Test plan