fix: relax pynini version constraint to >=2.1.6 - #345
Merged
Conversation
Remove upper bound on pynini version to allow installation with pynini 2.1.7+, which is easier to install on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
Closes #292
Closes #321
Closes #328
Summary
>=2.1.6,<2.1.7→>=2.1.6, fixing macOS installation ([Installation Error] Installation Error on MacOS - pynini #317, 1.0.4.1仅可以在Linux环境下安装成功，windows和mac下都无法安装成功 #292, install on windows #328)encoding="utf-8"when reading test data filesTest plan