Skip to content

fix: don't convert - to 减 in non-math context #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pengzhendong merged 3 commits into from
Jun 9, 2026
Merged

fix: don't convert - to 减 in non-math context #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ed6af
fix: don't convert - to 减 in non-math context (#294)
pengzhendong Jun 9, 2026
64348bd
ci: only test macOS/Windows on schedule and manual dispatch
pengzhendong Jun 9, 2026
6ac8983
ci: run macOS/Windows only on manual dispatch, Linux on PR
pengzhendong Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unittest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: ${{ github.event_name == 'pull_request' && fromJSON('["ubuntu-latest"]') || fromJSON('["ubuntu-latest", "macos-latest", "windows-latest"]') }}
python-version: ['3.9']
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 6 additions & 0 deletions tn/chinese/data/math/operator_unambiguous.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
× 乘
÷ 除
≥ 大于等于
≤ 小于等于
>= 大于等于
<= 小于等于
3 changes: 2 additions & 1 deletion tn/chinese/rules/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ def __init__(self, cardinal=None):

def build_tagger(self):
operator = string_file(get_abs_path("chinese/data/math/operator.tsv"))
unambiguous_operator = string_file(get_abs_path("chinese/data/math/operator_unambiguous.tsv"))
symbols = cross("~", "到") | cross(":", "比") | cross("<", "小于") | cross(">", "大于")

number = self.cardinal.number
tagger = number + (delete(" ").ques + (operator | symbols) + delete(" ").ques + number).star
tagger |= operator
tagger |= unambiguous_operator
tagger = insert('value: "') + tagger + insert('"')
self.tagger = self.add_tokens(tagger)
Loading