fix: only use digit-by-digit reading for 4-digit years - #349
Merged
Conversation
normalize(input, nbest=1) returns a single string (default, backward
compatible). normalize(input, nbest=N) returns a list of N-best results.
Example:
n.normalize('海淀区108号', nbest=3)
# ['海淀区一百零八号', '海淀区十八号', '海淀区幺零八号']
Previously 2-digit numbers followed by 年/年度/赛季 were read digit-by-digit (38年 => 三八年). Now only 4-digit years use this pattern, so 38年 => 三十八年 (via number) while 2024年 => 二零二四年.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302
Summary
Previously 2-digit numbers followed by 年/年度/赛季 were read digit-by-digit (e.g.
38年→三八年). Now only 4-digit years use this pattern. Shorter numbers go through the normal number reading.Examples
Test plan