Skip to content

Fix mobile toolbar#7818

Closed
CloCkWeRX wants to merge 7 commits into
wenzhixin:developfrom
CloCkWeRX:fix-mobile-toolbar
Closed

Fix mobile toolbar#7818
CloCkWeRX wants to merge 7 commits into
wenzhixin:developfrom
CloCkWeRX:fix-mobile-toolbar

Conversation

@CloCkWeRX
Copy link
Copy Markdown

@CloCkWeRX CloCkWeRX commented Apr 26, 2025

Blocked by #7819

  • Need to get test running locally. Codespaces is a bust.

🤔Type of Request

  • Bug fix
  • New feature
  • Improvement
  • Documentation
  • Other

🔗Resolves an issue?

Partially addresses #5189

📝Changelog

  • Core
  • Extensions

💡Example(s)?

☑️Self Check before Merge

⚠️ Please check all items below before reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@wenzhixin
Copy link
Copy Markdown
Owner

This PR seems to have incorrect changes. Looking at the diff, it removes toolbarAlign but the refactored code has bugs (e.g. missing this. prefix when calling renderButton, and referencing opts instead of this.options inside the method). Please close this PR for now and submit a corrected version with proper changes and description. Thanks!

@wenzhixin wenzhixin closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants