Fix guard against pageSize <= 0 causing division by zero in initPagination#8294
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a division-by-zero edge case in the core pagination module when pageSize is configured as 0 or a negative number, ensuring pageFrom/pageTo and totalPages calculations remain safe during initPagination().
Changes:
- Adds an early guard for
opts.pageSize <= 0to prevent invalid pagination math. - Falls back to “show all rows” behavior for invalid
pageSizevalues and logs aconsole.warnto aid debugging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔Type of Request
🔗Resolves an issue?
Replaces #8271
📝Changelog
Fix division by zero when
pageSizeis 0 or negative by moving the guard beforeif (opts.totalRows)to also cover thepageFrom/pageTocalculation. Addedconsole.warnfor invalid input to help developers detect configuration errors.💡Example(s)?
☑️Self Check before Merge