Skip to content

fix: avoid filter-control selection errors#8370

Open
puneetdixit200 wants to merge 1 commit into
wenzhixin:developfrom
puneetdixit200:fix-filter-control-caret-selection
Open

fix: avoid filter-control selection errors#8370
puneetdixit200 wants to merge 1 commit into
wenzhixin:developfrom
puneetdixit200:fix-filter-control-caret-selection

Conversation

@puneetdixit200

Copy link
Copy Markdown

🤔Type of Request

  • Bug fix
  • New feature
  • Improvement
  • Documentation
  • Other

🔗Resolves an issue?
Fix #7703

📝Changelog

  • Core
  • Extensions

Filter-control now restores caret position only for text-like controls. Select and date filter controls no longer attempt setSelectionRange, avoiding the console error after filtering.

💡Example(s)?
Covered by a focused unit test for setCaretPosition with text, date, and select controls.

☑️Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Verification:

  • yarn vitest run tests/extensions/filter-control/utils.test.js
  • yarn test:vitest
  • yarn eslint src/extensions/filter-control/utils.js tests/extensions/filter-control/utils.test.js
  • yarn lint:js
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console errors when filtering a column with a “select” filter

1 participant