refactor: logged-in dropdown as button not link#2
Closed
wesleyboar wants to merge 1 commit into
Closed
Conversation
Change the authenticated user dropdown toggle from an anchor element to a button element, which is semantically correct since it triggers an action (opens a dropdown) rather than navigating to a URL. - Remove href="#" and role="button" - Add type="button" - Change closing </a> to </button> Port of TACC/tup-ui#537 commit 4b63942 (with fix from b3a6487 applied inline, avoiding that intermediate invalid-HTML state). Co-authored-by: Wesley B <wesleyboar@users.noreply.github.com>
Owner
Author
|
Important Migrated to TACC#1256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Migrated to TACC#1256.
Overview
Port of TACC/tup-ui#537 commit 4b63942 and b3a6487.
Related
Changes
In
nav_portal.raw.html, changes the authenticated user dropdown toggle from<a href="#" role="button">to<button type="button">, which is semantically correct since the element triggers an action (opens a dropdown) rather than navigating anywhere.Testing