fix: resolve ShellCheck SC2034 and 7 BATS test failures

- fix(swap-usage-monitor): remove unused 'pagesize' variable (SC2034)
- fix(certificate-renewal-check): show_usage exits 2 on error paths so
  assert_failure tests pass; --help still exits 0
- fix(dns-lookup-check): same show_usage exit-code fix
- fix(log-error-summary): same show_usage exit-code fix
- fix(mysql-slow-query-report): same show_usage fix; also fix double-zero
  bug in 'total=$(grep -c ... || echo 0)' — grep -c already outputs 0
  on no matches, causing '0\n0' string that broke [[ -eq 0 ]] comparison
- fix(network-latency-report): same show_usage exit-code fix
- test(kernel-parameter-audit): fix grep regex '^    echo .OK:' to
  'echo .OK:' — actual indentation in script is 8 spaces, not 4
- test(mysql-slow-query-report): change sample Query_time 3.456789 to
  3.456000 so printf %.3f yields '3.456' matching the assertion

Author: wesleyscholl

scripts/certificate-renewal-check.sh

@@ -27,12 +27,12 @@ Examples:
   $(basename "$0") /etc/ssl/certs/my.crt
   $(basename "$0") --warn-days 60 --crit-days 14 example.com:443 api.example.com
 EOF
-    exit 0
+    exit "${1:-0}"
 }
 
 if [[ $# -eq 0 ]]; then
     echo "Error: at least one certificate file or host is required."
-    show_usage
+    show_usage 2
 fi
 
 TARGETS=()
@@ -47,14 +47,14 @@ while [[ $# -gt 0 ]]; do
             CRIT_DAYS="$2"
             if ! [[ "$CRIT_DAYS" =~ ^[0-9]+$ ]]; then echo "Error: crit-days must be an integer"; exit 1; fi
             shift 2 ;;
-        -*) echo "Error: unknown option '$1'"; show_usage ;;
+        -*) echo "Error: unknown option '$1'"; show_usage 2 ;;
         *) TARGETS+=("$1"); shift ;;
     esac
 done
 
 if [[ ${#TARGETS[@]} -eq 0 ]]; then
     echo "Error: at least one certificate file or host is required."
-    show_usage
+    show_usage 2
 fi
 
 if ! command -v openssl >/dev/null 2>&1; then

scripts/dns-lookup-check.sh

@@ -25,27 +25,27 @@ Examples:
   $(basename "$0") example.com api.example.com
   $(basename "$0") --expected 93.184.216.34 example.com
 EOF
-    exit 0
+    exit "${1:-0}"
 }
 
 if [[ $# -eq 0 ]]; then
     echo "Error: at least one hostname is required."
-    show_usage
+    show_usage 2
 fi
 
 HOSTNAMES=()
 while [[ $# -gt 0 ]]; do
     case "$1" in
         -h|--help) show_usage ;;
         -e|--expected) EXPECTED_IP="$2"; shift 2 ;;
-        -*) echo "Error: unknown option '$1'"; show_usage ;;
+        -*) echo "Error: unknown option '$1'"; show_usage 2 ;;
         *) HOSTNAMES+=("$1"); shift ;;
     esac
 done
 
 if [[ ${#HOSTNAMES[@]} -eq 0 ]]; then
     echo "Error: at least one hostname is required."
-    show_usage
+    show_usage 2
 fi
 
 if ! command -v dig >/dev/null 2>&1 && ! command -v nslookup >/dev/null 2>&1 && ! command -v host >/dev/null 2>&1; then

scripts/log-error-summary.sh

@@ -26,12 +26,12 @@ Examples:
   $(basename "$0") --top 5 --pattern "OOM" /var/log/kern.log
   $(basename "$0") /var/log/app/app.log
 EOF
-    exit 0
+    exit "${1:-0}"
 }
 
 if [[ $# -eq 0 ]]; then
     echo "Error: log file is required."
-    show_usage
+    show_usage 2
 fi
 
 EXTRA_PATTERNS=()
@@ -50,14 +50,14 @@ while [[ $# -gt 0 ]]; do
         -p|--pattern)
             EXTRA_PATTERNS+=("$2")
             shift 2 ;;
-        -*) echo "Error: unknown option '$1'"; show_usage ;;
+        -*) echo "Error: unknown option '$1'"; show_usage 2 ;;
         *) LOG_FILE="$1"; shift ;;
     esac
 done
 
 if [[ -z "$LOG_FILE" ]]; then
     echo "Error: log file is required."
-    show_usage
+    show_usage 2
 fi
 
 if [[ ! -f "$LOG_FILE" ]]; then

scripts/mysql-slow-query-report.sh

@@ -25,12 +25,12 @@ Examples:
   $(basename "$0") /var/log/mysql/mysql-slow.log
   $(basename "$0") --top 5 --min-time 2 /var/log/mysql/mysql-slow.log
 EOF
-    exit 0
+    exit "${1:-0}"
 }
 
 if [[ $# -eq 0 ]]; then
     echo "Error: slow query log file is required."
-    show_usage
+    show_usage 2
 fi
 
 while [[ $# -gt 0 ]]; do
@@ -50,14 +50,14 @@ while [[ $# -gt 0 ]]; do
                 exit 1
             fi
             shift 2 ;;
-        -*) echo "Error: unknown option '$1'"; show_usage ;;
+        -*) echo "Error: unknown option '$1'"; show_usage 2 ;;
         *) LOG_FILE="$1"; shift ;;
     esac
 done
 
 if [[ -z "${LOG_FILE:-}" ]]; then
     echo "Error: slow query log file is required."
-    show_usage
+    show_usage 2
 fi
 
 if [[ ! -f "$LOG_FILE" ]]; then
@@ -76,7 +76,8 @@ echo "  Min time:   ${MIN_TIME}s"
 echo "  Top N:      $TOP_N"
 echo "-----------------------------------------------------------"
 
-total=$(grep -c "^# Query_time:" "$LOG_FILE" 2>/dev/null || echo 0)
+total=0
+total=$(grep -c "^# Query_time:" "$LOG_FILE" 2>/dev/null) || total=0
 echo "Total slow queries in log: $total"
 echo ""
 

scripts/network-latency-report.sh

@@ -26,12 +26,12 @@ Examples:
   $(basename "$0") 8.8.8.8 1.1.1.1
   $(basename "$0") --count 10 --threshold 100 google.com
 EOF
-    exit 0
+    exit "${1:-0}"
 }
 
 if [[ $# -eq 0 ]]; then
     echo "Error: at least one host is required."
-    show_usage
+    show_usage 2
 fi
 
 HOSTS=()
@@ -52,14 +52,14 @@ while [[ $# -gt 0 ]]; do
                 exit 1
             fi
             shift 2 ;;
-        -*) echo "Error: unknown option '$1'"; show_usage ;;
+        -*) echo "Error: unknown option '$1'"; show_usage 2 ;;
         *) HOSTS+=("$1"); shift ;;
     esac
 done
 
 if [[ ${#HOSTS[@]} -eq 0 ]]; then
     echo "Error: at least one host is required."
-    show_usage
+    show_usage 2
 fi
 
 if ! command -v ping >/dev/null 2>&1; then

scripts/swap-usage-monitor.sh

@@ -51,8 +51,7 @@ get_swap_info() {
         fi
     else
         # macOS fallback via vm_stat
-        local pagesize total_pages free_pages
-        pagesize=$(getconf PAGESIZE 2>/dev/null || echo 4096)
+        local total_pages free_pages
         total_pages=$(sysctl -n vm.swapusage 2>/dev/null | awk '{print $3}' | tr -d 'M' || echo 0)
         free_pages=$(sysctl -n vm.swapusage  2>/dev/null | awk '{print $7}' | tr -d 'M' || echo 0)
         echo "$total_pages $free_pages 0"

tests/kernel-parameter-audit.bats

@@ -47,6 +47,6 @@ setup() {
 }
 
 @test "script outputs OK or FAIL or SKIP per parameter" {
-    run grep -qE "^    echo .OK:" "$SCRIPT_PATH"
+    run grep -qE "echo .OK:" "$SCRIPT_PATH"
     assert_success
 }

tests/mysql-slow-query-report.bats

@@ -52,7 +52,7 @@ teardown() {
 @test "script reports query time from sample log" {
     local sample_log="${TEST_DIR}/slow.log"
     cat > "$sample_log" << 'EOF'
-# Query_time: 3.456789 Lock_time: 0.000123 Rows_sent: 1 Rows_examined: 10000
+# Query_time: 3.456000 Lock_time: 0.000123 Rows_sent: 1 Rows_examined: 10000
 SELECT * FROM users WHERE email = 'test@example.com';
 EOF
     run bash "$SCRIPT_PATH" "$sample_log"