fix: prevent panic when project directory name shorter than 8 chars#2
Open
KevM wants to merge 3 commits into
Open
fix: prevent panic when project directory name shorter than 8 chars#2KevM wants to merge 3 commits into
KevM wants to merge 3 commits into
Conversation
…g and response_item logs
Gemini and Kimi stores were slicing directory names with [:8] without checking length first. Short names like "kevm" (4 chars) would panic with "slice bounds out of range [:8] with length 4". Add length checks in both stores before truncating display strings. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Author
|
Apparently this happened because my user directory name is only 4 characters long. 🤷🏼♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a panic in the TUI when Gemini or Kimi project directory names are shorter than 8 characters.
Both
gemini/store.goandkimi/store.gowere slicing directory names with[:8]without checking length first, causing panics like:This occurred when a directory name like "kevm" (4 chars) was encountered.
Changes
Test plan
🤖 Generated with Claude Code