Skip to content

fix: struct name collision in parseAbiParameter cache#282

Merged
tmm merged 3 commits into
wevm:mainfrom
dbarabashh:fix/struct-cache-collision
Nov 18, 2025
Merged

fix: struct name collision in parseAbiParameter cache#282
tmm merged 3 commits into
wevm:mainfrom
dbarabashh:fix/struct-cache-collision

Conversation

@dbarabashh
Copy link
Copy Markdown
Contributor

Fixes #272

Previously, parseAbiParameter cached results based only on the parameter name which caused issues when parsing different struct definitions with the same name. The second call would return the cached result from the first call, even though the struct definitions were different.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: a852ceb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
abitype Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 14, 2025

@dbarabashh is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (863dc48) to head (a852ceb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          26       26           
  Lines        6165     6166    +1     
  Branches      195      195           
=======================================
+ Hits         6159     6160    +1     
  Misses          5        5           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/abitype@282

commit: a852ceb

@tmm tmm merged commit dd74b54 into wevm:main Nov 18, 2025
20 of 21 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: parseAbiParameter caching

2 participants