mppx validate: Stripe testmode payment support (#641)

bensandler-stripe · web-flow · commit be7d166bb6ac · 2026-07-13T16:48:03.000-07:00
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;

  GIT_VALID_PII_OVERRIDE
diff --git a/.changeset/validate-stripe-payments.md b/.changeset/validate-stripe-payments.md
@@ -0,0 +1,5 @@
+---
+'mppx': patch
+---
+
+`mppx validate`: Stripe testmode payment support. Auto-detects Stripe CLI test keys and completes card payment flows end-to-end using a test card, with graceful livemode detection.
diff --git a/src/cli/plugins/stripe.ts b/src/cli/plugins/stripe.ts
@@ -19,12 +19,13 @@ export function stripe() {
       const stripeOpts = parseOptions(
         z.object({
           paymentMethod: z.string(),
+          secretKey: z.string().optional(),
         }),
         methodOpts,
-        ['paymentMethod'],
+        ['paymentMethod', 'secretKey'],
       )
 
-      const stripeSecretKey = process.env.MPPX_STRIPE_SECRET_KEY
+      const stripeSecretKey = stripeOpts.secretKey ?? process.env.MPPX_STRIPE_SECRET_KEY
       if (!stripeSecretKey)
         throw new Errors.IncurError({
           code: 'MISSING_ENV',
diff --git a/src/cli/validate.test.ts b/src/cli/validate.test.ts
@@ -677,3 +677,97 @@ describe('validate: multi-challenge', () => {
     expect(output).toContain('Amount is valid integer string (Got: 1.50)')
   })
 })
+
+describe('validate: payment methods coverage', () => {
+  test(
+    'every method in Constants.Methods produces a payment result',
+    { timeout: 15_000 },
+    async () => {
+      const methods = Object.values(Constants.Methods)
+      const challenges = methods.map((method) => ({
+        id: `${method}-id`,
+        realm: 'localhost',
+        method,
+        intent: 'charge',
+        request: { amount: '100', currency: 'usd', methodDetails: {} },
+        expires: new Date(Date.now() + 300_000).toISOString(),
+      })) as Challenge.Challenge[]
+
+      const header = challenges.map((c) => Challenge.serialize(c)).join(', ')
+      const server = await testServer((req, res) => {
+        const url = new URL(req.url!, 'http://localhost')
+        if (url.pathname === '/openapi.json') {
+          res.setHeader('Content-Type', 'application/json')
+          res.end(
+            JSON.stringify({
+              openapi: '3.1.0',
+              info: { title: 'T', version: '1' },
+              paths: {
+                '/api/test': {
+                  post: { 'x-payment-info': { amount: '100' }, responses: { '402': {} } },
+                },
+              },
+            }),
+          )
+          return
+        }
+        res.writeHead(402, { [Constants.Headers.wwwAuthenticate]: header })
+        res.end()
+      })
+      const { output } = await serve(['validate', server.url, '--outputJson', '--yes'])
+      const jsonStart = output.indexOf('{')
+      const jsonEnd = output.lastIndexOf('}')
+      const result = JSON.parse(output.slice(jsonStart, jsonEnd + 1))
+      const paymentLabels = result.endpoints[0].payment.map((r: { label: string }) => r.label)
+      for (const method of methods) {
+        expect(paymentLabels.some((l: string) => l.includes(`[${method}]`))).toBe(true)
+      }
+    },
+  )
+})
+
+describe('validate: JSON mode', () => {
+  function mainnetChallenge() {
+    return makeChallenge({
+      request: {
+        amount: '10000',
+        currency: '0x20c0000000000000000000000000000000000000',
+        recipient: '0x1234567890123456789012345678901234567890',
+        methodDetails: { chainId: 4217 },
+      },
+    } as Partial<Challenge.Challenge>)
+  }
+
+  function parseJson(output: string) {
+    const jsonStart = output.indexOf('{')
+    const jsonEnd = output.lastIndexOf('}')
+    return JSON.parse(output.slice(jsonStart, jsonEnd + 1))
+  }
+
+  test('does not prompt (non-interactive)', { timeout: 15_000 }, async () => {
+    const server = await mppServer(mainnetChallenge())
+    const { output } = await serve(['validate', server.url, '--outputJson'])
+    const result = parseJson(output)
+    const allPayment = result.endpoints.flatMap((ep: { payment: unknown[] }) => ep.payment)
+    expect(allPayment.length).toBeGreaterThan(0)
+    expect(allPayment.every((r: { severity: string }) => r.severity === 'skip')).toBe(true)
+  })
+
+  test('no console leaks before JSON', { timeout: 15_000 }, async () => {
+    const server = await mppServer(mainnetChallenge())
+    const { output } = await serve(['validate', server.url, '--outputJson', '--yes'])
+    const jsonStart = output.indexOf('{')
+    expect(jsonStart).toBeGreaterThanOrEqual(0)
+    const beforeJson = output.slice(0, jsonStart)
+    expect(beforeJson).not.toContain('Using wallet')
+    expect(beforeJson).not.toContain('Auto-approved')
+    expect(beforeJson).not.toContain('Attempting')
+  })
+
+  test('includes suggestions', { timeout: 15_000 }, async () => {
+    const server = await mppServer(mainnetChallenge())
+    const { output } = await serve(['validate', server.url, '--outputJson', '--yes'])
+    const result = parseJson(output)
+    expect(Array.isArray(result.suggestions)).toBe(true)
+  })
+})
diff --git a/src/cli/validate/challenge.ts b/src/cli/validate/challenge.ts
@@ -1,6 +1,8 @@
+import type { Chain } from 'viem'
+import * as viemChains from 'viem/chains'
+
 import * as Challenge from '../../Challenge.js'
 import * as Constants from '../../Constants.js'
-import { chainId as tempoChainIds } from '../../tempo/internal/defaults.js'
 import * as x402Header from '../../x402/Header.js'
 import { pc } from '../utils.js'
 import { buildUrl, extractRequestBodyFromDiscovery } from './discovery.js'
@@ -15,13 +17,13 @@ import {
   warn,
 } from './helpers.js'
 
+const allChains = Object.values(viemChains) as Chain[]
+
 function detectTestnet(challenge: Challenge.Challenge): boolean {
   const request = challenge.request as Record<string, unknown>
-  const methodDetails = request.methodDetails as Record<string, unknown> | undefined
-  if (typeof methodDetails?.chainId === 'number') {
-    return methodDetails.chainId !== tempoChainIds.mainnet
-  }
-  return false
+  const md = request.methodDetails as Record<string, unknown> | undefined
+  if (typeof md?.chainId !== 'number') return false
+  return allChains.find((c) => c.id === md.chainId)?.testnet === true
 }
 
 export async function validateChallenge(
@@ -279,7 +281,8 @@ function validateMethodFields(
     validateTempoFields(request, tag, results, challenge)
   else if (challenge.method === Constants.Methods.stripe)
     validateStripeFields(request, tag, results)
-  else if (challenge.method === Constants.Methods.evm) validateEvmFields(request, tag, results)
+  else if (challenge.method === Constants.Methods.evm)
+    validateEvmFields(challenge, request, tag, results)
 }
 
 function validateTempoFields(
@@ -384,6 +387,7 @@ function validateStripeFields(
 }
 
 function validateEvmFields(
+  challenge: Challenge.Challenge,
   request: Record<string, unknown>,
   tag: string,
   results: CheckResult[],
@@ -401,7 +405,8 @@ function validateEvmFields(
   }
 
   if (isValidAddress(request.currency)) {
-    results.push(check(`${tag}Valid currency address`))
+    const network = detectTestnet(challenge) ? 'testnet' : 'mainnet'
+    results.push(check(`${tag}Valid currency address`, network))
   } else {
     results.push(
       fail(
diff --git a/src/cli/validate/index.ts b/src/cli/validate/index.ts
@@ -39,6 +39,7 @@ const validate = Cli.create('validate', {
         query: c.options.query,
         verbose: c.options.verbose > 0,
         yes: c.options.yes,
+        interactive: false,
       })
       console.log(JSON.stringify(result, null, 2))
       const noEndpoints = result.endpoints.length === 0 && !c.options.endpoint
@@ -67,6 +68,7 @@ const validate = Cli.create('validate', {
       query: c.options.query,
       verbose: c.options.verbose > 0,
       yes: c.options.yes,
+      interactive: !!process.stdin.isTTY,
       onPaymentResults: (results) => printResults(results, counts),
     })) {
       switch (event.phase) {
@@ -106,7 +108,7 @@ const validate = Cli.create('validate', {
           if (event.isMpp) {
             sawMppEndpoint = true
             if (event.isTestnet) sawTestnet = true
-            else sawMainnet = true
+            if (event.isMainnet) sawMainnet = true
           }
           if (event.isNonMppPayment) sawNonMppPaymentEndpoint = true
           if (event.isMalformedChallenge) sawMalformedChallenge = true
@@ -208,13 +210,13 @@ function printSummary(
   if (flags.paymentSucceeded && flags.sawTestnet && !flags.sawMainnet) {
     console.log('')
     console.log(
-      pc.dim('  Tip: validate your mainnet server too to confirm real payments work end-to-end.'),
+      pc.dim('  Tip: also validate your mainnet server to confirm real payments work end-to-end.'),
     )
   } else if (flags.sawMainnet && !flags.sawTestnet) {
     console.log('')
     console.log(
       pc.dim(
-        '  Tip: validate a testnet server too for free. This CLI automatically provisions and funds a testnet wallet for testing.',
+        '  Tip: also validate your testnet server for free. This CLI automatically provisions and funds a testnet wallet for testing.',
       ),
     )
   }
diff --git a/src/cli/validate/payment.ts b/src/cli/validate/payment.ts
diff --git a/src/validation/core.ts b/src/validation/core.ts

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'mppx': patch
 +---
++
 +`mppx validate`: Stripe testmode payment support. Auto-detects Stripe CLI test keys and completes card payment flows end-to-end using a test card, with graceful livemode detection.