Skip to content

Clean up instance timeout handling#79

Open
chrisx9z wants to merge 1 commit into
wevm:mainfrom
chrisx9z:fix/catch-start-timeout
Open

Clean up instance timeout handling#79
chrisx9z wants to merge 1 commit into
wevm:mainfrom
chrisx9z:fix/catch-start-timeout

Conversation

@chrisx9z

Copy link
Copy Markdown

Summary

  • Ensures start() timeouts reject through the returned promise and reset the instance back to idle.
  • Prevents the original start task from flipping the instance to started after the timeout has already fired.
  • Clears timeout timers on successful start/stop paths and adds a patch changeset.

Fixes #44.

Verification

  • corepack pnpm install --ignore-scripts
  • corepack pnpm exec tsc --noEmit
  • corepack pnpm exec biome check src/Instance.ts src/Instance.test.ts .changeset/soft-rings-sip.md
  • corepack pnpm exec vitest src/Instance.test.ts --run
  • git diff --check

Note

  • vitest src/Instance.test.ts --run passes with 12 tests. It also reports existing warnings for two older .rejects assertions in unrelated tests that are not awaited.
  • Local Windows pnpm build currently fails because zile tries to spawn node_modules/.bin/tsc without the .CMD extension; the focused test was run after generating a local dist with tsc for package resolution.

Comment: Makes start timeouts reject cleanly without leaving instances stuck in a starting state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to handle async exception

1 participant